[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZoVZdp8fTOLXuYQe@localhost.localdomain>
Date: Wed, 3 Jul 2024 16:00:22 +0200
From: Michal Kubiak <michal.kubiak@...el.com>
To: Oleksij Rempel <o.rempel@...gutronix.de>
CC: "David S. Miller" <davem@...emloft.net>, Andrew Lunn <andrew@...n.ch>,
Eric Dumazet <edumazet@...gle.com>, Florian Fainelli <f.fainelli@...il.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, "Woojung
Huh" <woojung.huh@...rochip.com>, Arun Ramadoss
<arun.ramadoss@...rochip.com>, Heiner Kallweit <hkallweit1@...il.com>,
Russell King <linux@...linux.org.uk>, Yuiko Oshino
<yuiko.oshino@...rochip.com>, <kernel@...gutronix.de>,
<linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>,
<UNGLinuxDriver@...rochip.com>
Subject: Re: [PATCH net v1 1/2] net: phy: microchip: lan87xx: reinit PHY
after cable test
On Wed, Jul 03, 2024 at 03:28:00PM +0200, Oleksij Rempel wrote:
> Reinit PHY after cable test, otherwise link can't be established on
> tested port. This issue is reproducible on LAN9372 switches with
> integrated 100BaseT1 PHYs.
>
> Fixes: 788050256c411 ("net: phy: microchip_t1: add cable test support for lan87xx phy")
> Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de>
> ---
> drivers/net/phy/microchip_t1.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/phy/microchip_t1.c b/drivers/net/phy/microchip_t1.c
> index a838b61cd844b..a35528497a576 100644
> --- a/drivers/net/phy/microchip_t1.c
> +++ b/drivers/net/phy/microchip_t1.c
> @@ -748,7 +748,7 @@ static int lan87xx_cable_test_report(struct phy_device *phydev)
> ethnl_cable_test_result(phydev, ETHTOOL_A_CABLE_PAIR_A,
> lan87xx_cable_test_report_trans(detect));
>
> - return 0;
> + return phy_init_hw(phydev);
> }
>
> static int lan87xx_cable_test_get_status(struct phy_device *phydev,
> --
> 2.39.2
>
>
Thanks,
Reviewed-by: Michal Kubiak <michal.kubiak@...el.com>
Powered by blists - more mailing lists