netdev - Re: [PATCH net-next 01/11] net: ethtool: let drivers remove lost RSS contexts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <940cec84-36c6-82b8-7cef-b181156ff8e2@gmail.com>
Date: Wed, 3 Jul 2024 15:15:49 +0100
From: Edward Cree <ecree.xilinx@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
 pabeni@...hat.com, michael.chan@...adcom.com
Subject: Re: [PATCH net-next 01/11] net: ethtool: let drivers remove lost RSS
 contexts

On 03/07/2024 14:43, Jakub Kicinski wrote:
> On Wed, 3 Jul 2024 12:08:36 +0100 Edward Cree wrote:
>> Possibility of a netlink notification makes the idea of a broken flag
>>  a bit more workable imho.  But it's up to you which way to go.
> 
> Oh, have we talked about this? Now that you mention the broken flag 
> I recall talking about devlink health reporter.. a while back.
> 
> I don't have a preference on how we deal with the lost contexts.
> The more obvious we make it to orchestration that the machine is broken
> the better. Can you point me to the discussion / describe the broken
> flag?

We discussed it briefly on v4 back in October [1][2].  Idea was
 there'd be a flag in struct ethtool_rxfh_context with meaning of
 "this context is not present in hw owing to reinsertion failure
 after a device reset", reported in ethtool -x and perhaps also
 devlink health.  Driver could set this flag (which would trigger
 a netlink notification) but could also clear it if a second
 reset (or some runtime configuration change) triggers another
 round of reinsertion which succeeds this time.
Fwiw I don't have a strong preference either — like I say, you do
 what you think is best.

-ed

[1]: https://lore.kernel.org/all/2ea45188-5554-8067-820d-378cada735ee@gmail.com/T/#ma8fce7df8b65601009551839d9d102c49e79803a
[2]: https://lore.kernel.org/all/2ea45188-5554-8067-820d-378cada735ee@gmail.com/T/#m073cb990982d89e35d78edf364389de62256664b