netdev - Re: [RESEND PATCH net] net: ethernet: mtk-star-emac: set mac_managed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <696203057c047a668b72e8af2cf8fcc696649c17.camel@redhat.com>
Date: Thu, 04 Jul 2024 13:00:50 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Jian Hui Lee <jianhui.lee@...onical.com>, Felix Fietkau <nbd@....name>, 
 Sean Wang <sean.wang@...iatek.com>, Mark Lee <Mark-MC.Lee@...iatek.com>,
 Lorenzo Bianconi <lorenzo@...nel.org>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
 <kuba@...nel.org>, Matthias Brugger <matthias.bgg@...il.com>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 Florian Fainelli <f.fainelli@...il.com>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org,  linux-arm-kernel@...ts.infradead.org,
 linux-mediatek@...ts.infradead.org
Subject: Re: [RESEND PATCH net] net: ethernet: mtk-star-emac: set
 mac_managed_pm when probing

On Wed, 2024-07-03 at 14:18 +0800, Jian Hui Lee wrote:
> The below commit introduced a warning message when phy state is not in
> the states: PHY_HALTED, PHY_READY, and PHY_UP.
> commit 744d23c71af3 ("net: phy: Warn about incorrect mdio_bus_phy_resume() state")
> 
> mtk-star-emac doesn't need mdiobus suspend/resume. To fix the warning
> message during resume, indicate the phy resume/suspend is managed by the
> mac when probing.
> 
> Fixes: 744d23c71af3 ("net: phy: Warn about incorrect mdio_bus_phy_resume() state")
> Signed-off-by: Jian Hui Lee <jianhui.lee@...onical.com>
> ---
> resending to add the mailing list recipient
> 
>  drivers/net/ethernet/mediatek/mtk_star_emac.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/net/ethernet/mediatek/mtk_star_emac.c b/drivers/net/ethernet/mediatek/mtk_star_emac.c
> index 31aebeb2e285..79f8a8b72c27 100644
> --- a/drivers/net/ethernet/mediatek/mtk_star_emac.c
> +++ b/drivers/net/ethernet/mediatek/mtk_star_emac.c
> @@ -1525,6 +1525,7 @@ static int mtk_star_probe(struct platform_device *pdev)
>  	struct device_node *of_node;
>  	struct mtk_star_priv *priv;
>  	struct net_device *ndev;
> +	struct phy_device *phydev;

Please respect the reverse x-mas tree order above.

Thanks,

Paolo