netdev - Re: [PATCH] net: rswitch: Avoid use-after-free in rswitch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 04 Jul 2024 02:30:28 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Radu Rendec <rrendec@...hat.com>
Cc: yoshihiro.shimoda.uh@...esas.com, davem@...emloft.net, pabeni@...hat.com,
 niklas.soderlund+renesas@...natech.se, kuba@...nel.org, horms@...nel.org,
 netdev@...r.kernel.org, linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH] net: rswitch: Avoid use-after-free in rswitch_poll()

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Tue,  2 Jul 2024 17:08:37 -0400 you wrote:
> The use-after-free is actually in rswitch_tx_free(), which is inlined in
> rswitch_poll(). Since `skb` and `gq->skbs[gq->dirty]` are in fact the
> same pointer, the skb is first freed using dev_kfree_skb_any(), then the
> value in skb->len is used to update the interface statistics.
> 
> Let's move around the instructions to use skb->len before the skb is
> freed.
> 
> [...]

Here is the summary with links:
  - net: rswitch: Avoid use-after-free in rswitch_poll()
    https://git.kernel.org/netdev/net/c/9a0c28efeec6

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html