netdev - Re: [PATCH net-next] ntp: fix size argument for kcalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240704072155.2ea340a9@kernel.org>
Date: Thu, 4 Jul 2024 07:21:55 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Przemek Kitszel <przemyslaw.kitszel@...el.com>
Cc: Paolo Abeni <pabeni@...hat.com>, <oss-drivers@...igine.com>,
 <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
 <louis.peens@...igine.com>, <davem@...emloft.net>, <edumazet@...gle.com>,
 <horms@...nel.org>, <yinjun.zhang@...igine.com>, <johannes.berg@...el.com>,
 <ryno.swart@...igine.com>, <ziyang.chen@...igine.com>, <linma@....edu.cn>,
 <niklas.soderlund@...igine.com>, Chen Ni <nichen@...as.ac.cn>, "Sebastian
 Andrzej Siewior" <bigeasy@...utronix.de>
Subject: Re: [PATCH net-next] ntp: fix size argument for kcalloc

On Thu, 4 Jul 2024 12:17:39 +0200 Przemek Kitszel wrote:
> >> This patch is IMHO more a cleanup than a real fix. As such it's more
> >> suited for net-next. For the same reason I think it should not go to
> >> stable, so I'm dropping the fixes tag, too.  
> 
> I'm fine with targeting it at any of the trees.
> 
> But I still believe it is a fix, even if a trivial one, and even if code
> "works" - it's a "wrong" code.
> 
> Here I received similar feedback in a similar case:
> https://www.mail-archive.com/intel-wired-lan@osuosl.org/msg03252.html
> and I changed my mind then.

Comments, docs, and the MAINTAINERS file are special.
This is actually changing the code, and at present results in the same
binary getting generated.