[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240704074407.4cb4ebdf@kernel.org>
Date: Thu, 4 Jul 2024 07:44:07 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Ronald Wahl <rwahl@....de>
Cc: Ronald Wahl <ronald.wahl@...itan.com>, "David S. Miller"
<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
<pabeni@...hat.com>, Simon Horman <horms@...nel.org>,
netdev@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] ks8851: Fix deadlock with the SPI chip variant
On Wed, 3 Jul 2024 18:00:53 +0200 Ronald Wahl wrote:
> + bool need_wake_queue;
>
> netif_dbg(ks, intr, ks->netdev,
> "%s: txspace %d\n", __func__, tx_space);
>
> spin_lock(&ks->statelock);
> ks->tx_space = tx_space;
> - if (netif_queue_stopped(ks->netdev))
> - netif_wake_queue(ks->netdev);
> + need_wake_queue = netif_queue_stopped(ks->netdev);
> spin_unlock(&ks->statelock);
> + if (need_wake_queue)
> + netif_wake_queue(ks->netdev);
xmit runs in BH, this is just one way you can hit this deadlock
better fix would be to make sure statelock is always taken
using spin_lock_bh()
--
pw-bot: cr
Powered by blists - more mailing lists