netdev - Re: [PATCH net] net: bcmasp: Fix error code in probe()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZobEloyLq0OPShtf@localhost.localdomain>
Date: Thu, 4 Jul 2024 17:49:42 +0200
From: Michal Kubiak <michal.kubiak@...el.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
CC: Justin Chen <justin.chen@...adcom.com>, Florian Fainelli
	<florian.fainelli@...adcom.com>, "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, "Paolo
 Abeni" <pabeni@...hat.com>, Simon Horman <horms@...nel.org>,
	<bcm-kernel-feedback-list@...adcom.com>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH net] net: bcmasp: Fix error code in probe()

On Thu, Jul 04, 2024 at 10:19:44AM -0500, Dan Carpenter wrote:
> Return an error code if bcmasp_interface_create() fails.  Don't return

nitpick: redundant space after "fails."

> success.
> 
> Fixes: 490cb412007d ("net: bcmasp: Add support for ASP2.0 Ethernet controller")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---
>  drivers/net/ethernet/broadcom/asp2/bcmasp.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/broadcom/asp2/bcmasp.c b/drivers/net/ethernet/broadcom/asp2/bcmasp.c
> index a806dadc4196..20c6529ec135 100644
> --- a/drivers/net/ethernet/broadcom/asp2/bcmasp.c
> +++ b/drivers/net/ethernet/broadcom/asp2/bcmasp.c
> @@ -1380,6 +1380,7 @@ static int bcmasp_probe(struct platform_device *pdev)
>  			dev_err(dev, "Cannot create eth interface %d\n", i);
>  			bcmasp_remove_intfs(priv);
>  			of_node_put(intf_node);
> +			ret = -ENOMEM;
>  			goto of_put_exit;
>  		}
>  		list_add_tail(&intf->list, &priv->intfs);
> -- 
> 2.43.0
> 
> 

The patch actually fixes an obvious bug.

Thanks,
Reviewed-by: Michal Kubiak <michal.kubiak@...el.com>