netdev - Re: [PATCH net-next v13 09/15] net: stmmac: dwmac-loongson: Introduce PCI device info data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4c0e463f-bb44-44e5-9fc1-d0187e3229fd@loongson.cn>
Date: Thu, 4 Jul 2024 17:18:03 +0800
From: Yanteng Si <siyanteng@...ngson.cn>
To: Serge Semin <fancer.lancer@...il.com>
Cc: andrew@...n.ch, hkallweit1@...il.com, peppe.cavallaro@...com,
 alexandre.torgue@...s.st.com, joabreu@...opsys.com, Jose.Abreu@...opsys.com,
 chenhuacai@...nel.org, linux@...linux.org.uk, guyinggang@...ngson.cn,
 netdev@...r.kernel.org, chris.chenfeiyang@...il.com, si.yanteng@...ux.dev
Subject: Re: [PATCH net-next v13 09/15] net: stmmac: dwmac-loongson: Introduce
 PCI device info data


在 2024/7/2 17:18, Serge Semin 写道:
> On Wed, May 29, 2024 at 06:19:48PM +0800, Yanteng Si wrote:
>> Just introduce PCI device info data to prepare for later
>> ACPI-base support. Loongson machines may use UEFI (implies
>> ACPI) or PMON/UBOOT (implies FDT) as the BIOS.
>>
>> The BIOS type has no relationship with device types, which
>> means: machines can be either ACPI-based or FDT-based.
> AFAICS the commit log is misleading because the DT-less (ACPI-based)
> setups is being added in the next commit and it's implemented by using
> the if-else statement with no setup() callback infrastructure
> utilized.
>
> But this change is still needed for adding the Loongson GNET support
> later in the series. The setup() callback will be pre-initialized with
> the network controller specific method based on the PCIe Device ID. So
> to speak, please alter the commit log with the correct justification.
> Like this:
>
> "The Loongson GNET device support is about to be added in one of the
> next commits. As another preparation for that introduce the PCI device
> info data with a setup() callback performing the device-specific
> platform data initializations. Currently it is utilized for the
> already supported Loongson GMAC device only."
>
Ok, Thanks!


Thanks,

Yanteng