netdev - Re: [PATCH net-next v13 13/15] net: stmmac: dwmac-loongson: Drop pci_enable/disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 4 Jul 2024 17:32:22 +0800
From: Yanteng Si <siyanteng@...ngson.cn>
To: Serge Semin <fancer.lancer@...il.com>
Cc: andrew@...n.ch, hkallweit1@...il.com, peppe.cavallaro@...com,
 alexandre.torgue@...s.st.com, joabreu@...opsys.com, Jose.Abreu@...opsys.com,
 chenhuacai@...nel.org, linux@...linux.org.uk, guyinggang@...ngson.cn,
 netdev@...r.kernel.org, chris.chenfeiyang@...il.com, si.yanteng@...ux.dev
Subject: Re: [PATCH net-next v13 13/15] net: stmmac: dwmac-loongson: Drop
 pci_enable/disable_msi temporarily


在 2024/7/1 09:17, Serge Semin 写道:
>> [PATCH net-next v13 13/15] net: stmmac: dwmac-loongson: Drop pci_enable/disable_msi temporarily
> You don't drop the methods call "temporarily" but forever. So fix
> the subject like this please:
> [PATCH net-next v13 13/15] net: stmmac: dwmac-loongson: Drop pci_enable_msi/disable_msi methods call
>
> I understand that you meant that the MSI IRQs support will be
> added later in framework of another commit and for the multi-channel
> device case. But mentioning that in a way you did makes the commit log
> more confusing than better explaining the change.
>
> On Wed, May 29, 2024 at 06:21:08PM +0800, Yanteng Si wrote:
>> The LS2K2000 patch added later will alloc vectors, so let's
>> remove pci_enable/disable_msi temporarily to prepare for later
>> calls to pci_alloc_irq_vectors/pci_free_irq_vectors. This does
>> not affect the work of gmac devices, as they actually use intx.
> As I mentioned in v12 AFAICS the MSI IRQs haven't been utilized on the
> Loongseon GMAC devices so far since the IRQ numbers have been retrieved
> directly from device DT-node. That's what you should have mentioned in
> the log. Like this:
> "The Loongson GMAC driver currently doesn't utilize the MSI IRQs, but
> retrieves the IRQs specified in the device DT-node. Let's drop the
> direct pci_enable_msi()/pci_disable_msi() calls then as redundant."
>
> If what I said was correct and MSIs enable wasn't required for the
> platform IRQs to work, then please use the log and move this patch to
> being submitted between
> [PATCH net-next v13 04/15] net: stmmac: dwmac-loongson: Drop duplicated hash-based filter size init
> and
> [PATCH net-next v13 05/15] net: stmmac: dwmac-loongson: Use PCI_DEVICE_DATA() macro for device identification
>
> so the redundant pci_enable_msi()/pci_disable_msi() code wouldn't be
> getting on a way of the subsequent preparation changes.

Ok, Thanks!


Thanks,

Yanteng