netdev - Re: [PATCH net-next v13 14/15] net: stmmac: dwmac-loongson: Add Loongson GNET support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8652851c-a407-4e20-b3f3-11a8a797debf@loongson.cn>
Date: Fri, 5 Jul 2024 20:06:32 +0800
From: Yanteng Si <siyanteng@...ngson.cn>
To: Serge Semin <fancer.lancer@...il.com>, Huacai Chen <chenhuacai@...nel.org>
Cc: andrew@...n.ch, hkallweit1@...il.com, peppe.cavallaro@...com,
 alexandre.torgue@...s.st.com, joabreu@...opsys.com, Jose.Abreu@...opsys.com,
 linux@...linux.org.uk, guyinggang@...ngson.cn, netdev@...r.kernel.org,
 chris.chenfeiyang@...il.com, si.yanteng@...ux.dev
Subject: Re: [PATCH net-next v13 14/15] net: stmmac: dwmac-loongson: Add
 Loongson GNET support

>>> But if you aren't comfortable with such naming we can change the
>>> macro to something like:
>>> #define DWMAC_CORE_LOONGSON_MULTI_CH    0x10
>> Maybe DWMAC_CORE_LOONGSON_MULTICHAN or DWMAC_CORE_LOONGSON_MULTI_CHAN
>> is a little better?
>>
> Well, I don't have a strong opinion about that in this case.
> Personally I prefer to have the shortest and still readable version.
> It decreases the probability of the lines splitting in case of the
> long-line statements or highly indented code. From that perspective
> something like DWMAC_CORE_LS_MULTI_CH would be even better. But seeing
> the driver currently don't have such cases, we can use any of those
> name. But it's better to be of such length so the code lines the name
> is utilized in wouldn't exceed +80 chars.

Okay.

I added an indent before 0xXX and left three Spaces before the comment,

which uses huacai's MULTICHAN and doesn't exceed 80 chars.


Thanks,

Yanteng