netdev - Re: [PATCH net-next] net: page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ac90ee8aa46a8d6dd9710a981545c14bf881f918.camel@sipsolutions.net>
Date: Fri, 05 Jul 2024 14:33:31 +0200
From: Johannes Berg <johannes@...solutions.net>
To: Alexander Lobakin <aleksander.lobakin@...el.com>
Cc: netdev@...r.kernel.org, Jesper Dangaard Brouer <hawk@...nel.org>, Ilias
 Apalodimas <ilias.apalodimas@...aro.org>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
 <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net-next] net: page_pool: fix warning code

On Fri, 2024-07-05 at 14:32 +0200, Alexander Lobakin wrote:
> From: Johannes Berg <johannes@...solutions.net>
> Date: Fri,  5 Jul 2024 13:42:06 +0200
> 
> > From: Johannes Berg <johannes.berg@...el.com>
> > 
> > WARN_ON_ONCE("string") doesn't really do what appears to
> > be intended, so fix that.
> > 
> > Signed-off-by: Johannes Berg <johannes.berg@...el.com>
> 
> "Fixes:" tag?

There keep being discussions around this so I have no idea what's the
guideline-du-jour ... It changes the code but it's not really an issue?

johannes