[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <f5754d0a-1640-4d20-95fd-a2d74dfcc084@intel.com>
Date: Fri, 5 Jul 2024 14:45:50 +0200
From: Alexander Lobakin <aleksander.lobakin@...el.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
<edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, David Ahern
<dsahern@...nel.org>, Xuan Zhuo <xuanzhuo@...ux.alibaba.com>, Andrew Lunn
<andrew@...n.ch>, <nex.sw.ncis.osdt.itp.upstreaming@...el.com>,
<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next v2 5/5] netdev_features: convert NETIF_F_FCOE_MTU
to dev->fcoe_mtu
From: Jakub Kicinski <kuba@...nel.org>
Date: Thu, 4 Jul 2024 19:16:46 -0700
> On Wed, 3 Jul 2024 17:03:42 +0200 Alexander Lobakin wrote:
>> --- a/net/8021q/vlan_dev.c
>> +++ b/net/8021q/vlan_dev.c
>> @@ -571,6 +571,7 @@ static int vlan_dev_init(struct net_device *dev)
>>
>> dev->features |= dev->hw_features;
>> dev->lltx = true;
>> + dev->fcoe_mtu = true;
>
> why?
Because (couple lines above on the baseline):
dev->hw_features = NETIF_F_HW_CSUM | NETIF_F_SG |
NETIF_F_FRAGLIST | NETIF_F_GSO_SOFTWARE |
NETIF_F_GSO_ENCAP_ALL |
NETIF_F_HIGHDMA | NETIF_F_SCTP_CRC |
NETIF_F_ALL_FCOE;
^^^^^^^^^^^^^^^^
then
dev->features |= dev->hw_features | NETIF_F_LLTX;
^^^^^^^^^^^^^^^^
#define NETIF_F_ALL_FCOE (NETIF_F_FCOE_CRC | NETIF_F_FCOE_MTU | \
NETIF_F_FSO)
^^^^^^^^^^^^^^^^
IOW, FCOE_MTU was always hitting dev->features previously :>
Re rebase due to 1/5: yeah unfortunately, but that happens :D
I'll rebase and resend on Monday.
Thanks,
Olek
Powered by blists - more mailing lists