netdev - Re: [PATCH iwl-next] i40e: correct i40e_addr_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9d38d987-6968-4495-8311-ad846d6cde89@intel.com>
Date: Fri, 5 Jul 2024 15:24:41 +0200
From: Przemek Kitszel <przemyslaw.kitszel@...el.com>
To: Simon Horman <horms@...nel.org>, Tony Nguyen <anthony.l.nguyen@...el.com>
CC: <intel-wired-lan@...ts.osuosl.org>, <netdev@...r.kernel.org>
Subject: Re: [PATCH iwl-next] i40e: correct i40e_addr_to_hkey() name in kdoc

On 7/5/24 15:15, Simon Horman wrote:
> Correct name of i40e_addr_to_hkey() in it's kdoc.
> 
> kernel-doc -none reports:
> 
>   drivers/net/ethernet/intel/i40e/i40e.h:739: warning: expecting prototype for i40e_mac_to_hkey(). Prototype was for i40e_addr_to_hkey() instead
> 
> Signed-off-by: Simon Horman <horms@...nel.org>

thank you,
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>

(unrelated digression below)

> ---
>   drivers/net/ethernet/intel/i40e/i40e.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/i40e/i40e.h b/drivers/net/ethernet/intel/i40e/i40e.h
> index bca2084cc54b..d546567e0286 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e.h
> +++ b/drivers/net/ethernet/intel/i40e/i40e.h
> @@ -735,7 +735,7 @@ __i40e_pf_next_veb(struct i40e_pf *pf, int *idx)
>   	     _i++, _veb = __i40e_pf_next_veb(_pf, &_i))
>   
>   /**
> - * i40e_mac_to_hkey - Convert a 6-byte MAC Address to a u64 hash key
> + * i40e_addr_to_hkey - Convert a 6-byte MAC Address to a u64 hash key
>    * @macaddr: the MAC Address as the base key
>    *
>    * Simply copies the address and returns it as a u64 for hashing
> 

I really look forward to the day that sender will be able to add
metadata to the patch displaying options - here changing context to 5
would make review an instant thing, as now there is no signature line:
static inline u64 i40e_addr_to_hkey(const u8 *macaddr).
But if Simon will send like that, this will be lost when applied to 
Tony's tree.

I'm picking such trivial patch to bring the topic to don't derail any
which will have it's own on-topic discussion, but this is for the
benefit of reviewers of bigger changes of course.