netdev - Re: [PATCH net 4/4] selftests: vrf_route

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <83f8423b-3ac6-4e62-a1ab-11fddb385753@6wind.com>
Date: Fri, 5 Jul 2024 15:34:09 +0200
From: Nicolas Dichtel <nicolas.dichtel@...nd.com>
To: Simon Horman <horms@...nel.org>
Cc: "David S. Miller" <davem@...emloft.net>, Jakub Kicinski
 <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Eric Dumazet <edumazet@...gle.com>, David Ahern <dsahern@...nel.org>,
 netdev@...r.kernel.org
Subject: Re: [PATCH net 4/4] selftests: vrf_route_leaking: add local ping test

Le 27/06/2024 à 12:57, Simon Horman a écrit :
> On Mon, Jun 24, 2024 at 03:07:56PM +0200, Nicolas Dichtel wrote:
>> The goal is to check that the source address selected by the kernel is
>> routable when a leaking route is used.
>>
>> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>
>> ---
>>  .../selftests/net/vrf_route_leaking.sh        | 38 ++++++++++++++++++-
>>  1 file changed, 36 insertions(+), 2 deletions(-)
>>
>> diff --git a/tools/testing/selftests/net/vrf_route_leaking.sh b/tools/testing/selftests/net/vrf_route_leaking.sh
>> index 2da32f4c479b..6c59e0bbbde3 100755
>> --- a/tools/testing/selftests/net/vrf_route_leaking.sh
>> +++ b/tools/testing/selftests/net/vrf_route_leaking.sh
>> @@ -533,6 +533,38 @@ ipv6_ping_frag_asym()
>>  	ipv6_ping_frag asym
>>  }
>>  
>> +ipv4_ping_local()
>> +{
>> +	local ttype="$1"
>> +
>> +	[ "x$ttype" = "x" ] && ttype="$DEFAULT_TTYPE"
> 
> Hi Nicolas,
> 
> I see this pattern already elsewhere in this file, but shellecheck flags that:
> 
> 1. No arguments are passed to ipv4_ping_local
Yes, I don't add an asymmetric version of this test, I don't think that's
relevant. I wanted to keep it to be consistent with other tests.

> 2. The condition can be more simply expressed as [ "$ttype" = "" ]
>    (my 2c worth would be [ -z "$ttype" ])
Yeah, I asked myself also, but like for the previous point, I wanted to be
consistent with other tests.

I will remove this test.


Thank you,
Nicolas