netdev - Re: [PATCH net-next] net: page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7eab05e6-4192-4888-9b6a-6427dc709623@lunn.ch>
Date: Fri, 5 Jul 2024 16:19:40 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Johannes Berg <johannes@...solutions.net>
Cc: Alexander Lobakin <aleksander.lobakin@...el.com>,
	netdev@...r.kernel.org, Jesper Dangaard Brouer <hawk@...nel.org>,
	Ilias Apalodimas <ilias.apalodimas@...aro.org>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net-next] net: page_pool: fix warning code

On Fri, Jul 05, 2024 at 02:33:31PM +0200, Johannes Berg wrote:
> On Fri, 2024-07-05 at 14:32 +0200, Alexander Lobakin wrote:
> > From: Johannes Berg <johannes@...solutions.net>
> > Date: Fri,  5 Jul 2024 13:42:06 +0200
> > 
> > > From: Johannes Berg <johannes.berg@...el.com>
> > > 
> > > WARN_ON_ONCE("string") doesn't really do what appears to
> > > be intended, so fix that.
> > > 
> > > Signed-off-by: Johannes Berg <johannes.berg@...el.com>
> > 
> > "Fixes:" tag?
> 
> There keep being discussions around this so I have no idea what's the
> guideline-du-jour ... It changes the code but it's not really an issue?

https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html

> It must either fix a real bug that bothers people or just add a device ID.

It is clearly not the last. So does this actually bother people? I
would say no, the WARN_ON_ONCE() will fire, it will just not be as
helpful as it could be. So for me, this is net-next material and no
need to have it backported to stable.

	Andrew