netdev - Re: [PATCH net-next] net: page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <98fe3c75-6916-4f93-ae7e-be80e60afebf@intel.com>
Date: Fri, 5 Jul 2024 16:33:59 +0200
From: Alexander Lobakin <aleksander.lobakin@...el.com>
To: Johannes Berg <johannes@...solutions.net>, Andrew Lunn <andrew@...n.ch>
CC: <netdev@...r.kernel.org>, Jesper Dangaard Brouer <hawk@...nel.org>, "Ilias
 Apalodimas" <ilias.apalodimas@...aro.org>, "David S. Miller"
	<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net-next] net: page_pool: fix warning code

From: Johannes Berg <johannes@...solutions.net>
Date: Fri, 05 Jul 2024 16:23:43 +0200

> On Fri, 2024-07-05 at 16:19 +0200, Andrew Lunn wrote:
>> On Fri, Jul 05, 2024 at 02:33:31PM +0200, Johannes Berg wrote:
>>> On Fri, 2024-07-05 at 14:32 +0200, Alexander Lobakin wrote:
>>>> From: Johannes Berg <johannes@...solutions.net>
>>>> Date: Fri,  5 Jul 2024 13:42:06 +0200
>>>>
>>>>> From: Johannes Berg <johannes.berg@...el.com>
>>>>>
>>>>> WARN_ON_ONCE("string") doesn't really do what appears to
>>>>> be intended, so fix that.
>>>>>
>>>>> Signed-off-by: Johannes Berg <johannes.berg@...el.com>
>>>>
>>>> "Fixes:" tag?
>>>
>>> There keep being discussions around this so I have no idea what's the
>>> guideline-du-jour ... It changes the code but it's not really an issue?
>>
>> https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
> 
> And ... by referring to that you just made a guideline(-du-jour!) that
> "Fixes" tag must be accompanied by "Cc: stable@" (because Fixes
> _doesn't_ imply stable backport!), and then you apply the stable rules

The netdev ML is an exception, IIRC we never add "Cc: stable@" and then
after hitting Linus' tree at least some commits with "Fixes:" appears
magically in the stable trees :D

> to that.

Thanks,
Olek