[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <5e81ddd2-b6c8-46f4-8a9b-2db521ea1739@pengutronix.de>
Date: Fri, 5 Jul 2024 10:24:07 +0200
From: Bastian Krause <bst@...gutronix.de>
To: Stephen Hemminger <stephen@...workplumber.org>
Cc: Fabian Pfitzner <f.pfitzner@...gutronix.de>, mkubecek@...e.cz,
netdev@...r.kernel.org
Subject: Re: [PATCH ethtool 1/2]: add json support for base command
On 7/4/24 8:05 PM, Stephen Hemminger wrote:
> On Thu, 4 Jul 2024 17:21:16 +0200
> Bastian Krause <bst@...gutronix.de> wrote:
>
>>> if (pause)
>>> - printf("%s\n", asym ? "Symmetric Receive-only" : "Symmetric");
>>> + print_string(PRINT_ANY, label_json, "%s\n",
>>> + asym ? "Symmetric Receive-only" : "Symmetric");
>>> else
>>> - printf("%s\n", asym ? "Transmit-only" : "No");
>>> + print_string(PRINT_ANY, label_json, "%s\n", asym ? "Transmit-only" : "No");
>
>
> JSON has boolean type, why is this not ysed here?
As far as I can see, the
"supported-pause-frame-use"/"advertised-pause-frame-use" field's value
can currently be "Symmetric Receive-only", "Symmetric", "Transmit-only"
or "No". How would you put that into a boolean?
Regards,
Bastian
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Powered by blists - more mailing lists