netdev - Re: [PATCH net] tcp: fix incorrect undo caused by DSACK of TLP retransmit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <172022943026.18706.18202616674867302507.git-patchwork-notify@kernel.org>
Date: Sat, 06 Jul 2024 01:30:30 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Neal Cardwell <ncardwell.sw@...il.com>
Cc: davem@...emloft.net, kuba@...nel.org, edumazet@...gle.com,
 netdev@...r.kernel.org, ncardwell@...gle.com, ycheng@...gle.com,
 yyd@...gle.com
Subject: Re: [PATCH net] tcp: fix incorrect undo caused by DSACK of TLP retransmit

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Wed,  3 Jul 2024 13:12:46 -0400 you wrote:
> From: Neal Cardwell <ncardwell@...gle.com>
> 
> Loss recovery undo_retrans bookkeeping had a long-standing bug where a
> DSACK from a spurious TLP retransmit packet could cause an erroneous
> undo of a fast recovery or RTO recovery that repaired a single
> really-lost packet (in a sequence range outside that of the TLP
> retransmit). Basically, because the loss recovery state machine didn't
> account for the fact that it sent a TLP retransmit, the DSACK for the
> TLP retransmit could erroneously be implicitly be interpreted as
> corresponding to the normal fast recovery or RTO recovery retransmit
> that plugged a real hole, thus resulting in an improper undo.
> 
> [...]

Here is the summary with links:
  - [net] tcp: fix incorrect undo caused by DSACK of TLP retransmit
    https://git.kernel.org/netdev/net/c/0ec986ed7bab

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html