netdev - Re: [PATCH net-next v13 14/15] net: stmmac: dwmac-loongson: Add Loongson GNET support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2b819d91-8c2a-4262-9cbb-c10e520f10c9@loongson.cn>
Date: Sat, 6 Jul 2024 18:30:53 +0800
From: Yanteng Si <siyanteng@...ngson.cn>
To: Serge Semin <fancer.lancer@...il.com>
Cc: Huacai Chen <chenhuacai@...nel.org>, andrew@...n.ch,
 hkallweit1@...il.com, peppe.cavallaro@...com, alexandre.torgue@...s.st.com,
 joabreu@...opsys.com, Jose.Abreu@...opsys.com, linux@...linux.org.uk,
 guyinggang@...ngson.cn, netdev@...r.kernel.org, chris.chenfeiyang@...il.com,
 si.yanteng@...ux.dev
Subject: Re: [PATCH net-next v13 14/15] net: stmmac: dwmac-loongson: Add
 Loongson GNET support


在 2024/7/5 20:17, Serge Semin 写道:
> On Fri, Jul 05, 2024 at 08:06:32PM +0800, Yanteng Si wrote:
>>>>> But if you aren't comfortable with such naming we can change the
>>>>> macro to something like:
>>>>> #define DWMAC_CORE_LOONGSON_MULTI_CH    0x10
>>>> Maybe DWMAC_CORE_LOONGSON_MULTICHAN or DWMAC_CORE_LOONGSON_MULTI_CHAN
>>>> is a little better?
>>>>
>>> Well, I don't have a strong opinion about that in this case.
>>> Personally I prefer to have the shortest and still readable version.
>>> It decreases the probability of the lines splitting in case of the
>>> long-line statements or highly indented code. From that perspective
>>> something like DWMAC_CORE_LS_MULTI_CH would be even better. But seeing
>>> the driver currently don't have such cases, we can use any of those
>>> name. But it's better to be of such length so the code lines the name
>>> is utilized in wouldn't exceed +80 chars.
>> Okay.
>>
>> I added an indent before 0xXX and left three Spaces before the comment,
>>
>> which uses huacai's MULTICHAN and doesn't exceed 80 chars.
> I meant that it's better to have the length of the macro name so
> !the code where it's utilized!
> wouldn't exceed +80 chars. That's the criteria for the upper length
> boundary I normally follow in such cases.
>
Oh, I see!

Hmm, let's compare the two options:

DWMAC_CORE_LS_MULTI_CH

DWMAC_CORE_LS_MULTICHAN

With just one more char, the increased readability seems to be
worth it.


Thanks,

Yanteng