netdev - Re: [PATCH net-next v7 00/10] virtio-net: support AF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1720401065.058343-1-xuanzhuo@linux.alibaba.com>
Date: Mon, 8 Jul 2024 09:11:05 +0800
From: Xuan Zhuo <xuanzhuo@...ux.alibaba.com>
To: Michal Kubiak <michal.kubiak@...el.com>
Cc: <netdev@...r.kernel.org>,
 "Michael S. Tsirkin" <mst@...hat.com>,
 Jason Wang <jasowang@...hat.com>,
 Eugenio Pérez <eperezma@...hat.com>,
 "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>,
 Alexei Starovoitov <ast@...nel.org>,
 Daniel Borkmann <daniel@...earbox.net>,
 Jesper Dangaard Brouer <hawk@...nel.org>,
 John Fastabend <john.fastabend@...il.com>,
 <virtualization@...ts.linux.dev>,
 <bpf@...r.kernel.org>
Subject: Re: [PATCH net-next v7 00/10] virtio-net: support AF_XDP zero copy

On Fri, 5 Jul 2024 16:14:04 +0200, Michal Kubiak <michal.kubiak@...el.com> wrote:
> On Fri, Jul 05, 2024 at 03:37:24PM +0800, Xuan Zhuo wrote:
> > v6:
> >     1. start from supporting the rx zerocopy
> >
> > v5:
> >     1. fix the comments of last version
> >         http://lore.kernel.org/all/20240611114147.31320-1-xuanzhuo@linux.alibaba.com
> > v4:
> >     1. remove the commits that introduce the independent directory
> >     2. remove the supporting for the rx merge mode (for limit 15
> >        commits of net-next). Let's start with the small mode.
> >     3. merge some commits and remove some not important commits
> >
> > ## AF_XDP
> >
> > XDP socket(AF_XDP) is an excellent bypass kernel network framework. The zero
> > copy feature of xsk (XDP socket) needs to be supported by the driver. The
> > performance of zero copy is very good. mlx5 and intel ixgbe already support
> > this feature, This patch set allows virtio-net to support xsk's zerocopy xmit
> > feature.
> >
> > At present, we have completed some preparation:
> >
> > 1. vq-reset (virtio spec and kernel code)
> > 2. virtio-core premapped dma
> > 3. virtio-net xdp refactor
> >
> > So it is time for Virtio-Net to complete the support for the XDP Socket
> > Zerocopy.
> >
> >
>
> After taking a look at this series I haven't found adding
> NETDEV_XDP_ACT_XSK_ZEROCOPY flag to netdev->xdp_features.
> Is it intentional or just an oversight?

Because there are too many commits, the work of virtio net supporting af-xdp is
split to rx part and tx part. This patch set is for rx part. The flags will be
update after tx part.

Thanks.

>
> Thanks,
> Michal