netdev - Re: [PATCH net-next] netxen_nic: Use {low,upp}er_32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240708110511.GM1481495@kernel.org>
Date: Mon, 8 Jul 2024 12:05:11 +0100
From: Simon Horman <horms@...nel.org>
To: Geert Uytterhoeven <geert+renesas@...der.be>
Cc: Manish Chopra <manishc@...vell.com>, Rahul Verma <rahulv@...vell.com>,
	GR-Linux-NIC-Dev@...vell.com,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] netxen_nic: Use {low,upp}er_32_bits() helpers

On Mon, Jul 08, 2024 at 11:25:14AM +0200, Geert Uytterhoeven wrote:
> Use the existing {low,upp}er_32_bits() helpers instead of defining
> custom variants.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>

Hi Geert,

I agree your patch is a good cleanup, so from that PoV.

Reviewed-by: Simon Horman <horms@...nel.org>

But it also also seems to me that the last non-cleanup fix this patch
received was the following commit in May 2012, which was included in v4.0.

commit 01da0c2b0391 ("netxen_nic: Fix estimation of recv MSS in case of LRO")

So I do wonder if rather than cleaning up this driver,
we should discuss if it should be removed.

...