[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <74128e54-51b9-4199-924e-a4e50b6f34cb@lunn.ch>
Date: Mon, 8 Jul 2024 15:33:17 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Oleksij Rempel <o.rempel@...gutronix.de>
Cc: Michal Kubecek <mkubecek@...e.cz>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Jiri Pirko <jiri@...nulli.us>,
Vladimir Oltean <vladimir.oltean@....com>,
Arun Ramadoss <arun.ramadoss@...rochip.com>,
Woojung.Huh@...rochip.com, kernel@...gutronix.de,
netdev@...r.kernel.org, UNGLinuxDriver@...rochip.com,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH net v2 1/1] ethtool: netlink: do not return SQI value if
link is down
On Sat, Jul 06, 2024 at 07:49:00AM +0200, Oleksij Rempel wrote:
> Do not attach SQI value if link is down. "SQI values are only valid if
> link-up condition is present" per OpenAlliance specification of
> 100Base-T1 Interoperability Test suite [1]. The same rule would apply
> for other link types.
>
> [1] https://opensig.org/automotive-ethernet-specifications/#
>
> Fixes: 806602191592 ("ethtool: provide UAPI for PHY Signal Quality Index (SQI)")
> Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de>
Reviewed-by: Andrew Lunn <andrew@...n.ch>
Andrew
Powered by blists - more mailing lists