netdev - Re: [PATCH] net/mlx4: Add support for EEPROM high pages query for QSFP/QSFP+/QSFP28

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZowTsiQdTyLJkdc4@shredder.mtl.com>
Date: Mon, 8 Jul 2024 19:28:38 +0300
From: Ido Schimmel <idosch@...dia.com>
To: Krzysztof Olędzki <ole@....pl>
Cc: Andrew Lunn <andrew@...n.ch>, Michal Kubecek <mkubecek@...e.cz>,
	Moshe Shemesh <moshe@...dia.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	tariqt@...dia.com, Dan Merillat <git@....merillat.org>
Subject: Re: [PATCH] net/mlx4: Add support for EEPROM high pages query for
 QSFP/QSFP+/QSFP28

Hi, similar comments as on the other patch. Subject prefix should be
"[PATCH net-next]" instead of "[PATCH]". Need to copy maintainers
according to the output of "scripts/get_maintainer.pl". Missing SoB
(scripts/checkpatch.pl should flag it). I suggest reading the following
before submitting v2:

https://www.kernel.org/doc/html/latest/process/submitting-patches.html
https://docs.kernel.org/process/maintainer-netdev.html

On Sun, Jul 07, 2024 at 08:41:31PM -0700, Krzysztof Olędzki wrote:
> Enable reading additional EEPROM information from high pages such as
> thresholds and alarms on QSFP/QSFP+/QSFP28 modules.
> 
> The fix is similar to a708fb7b1f8dcc7a8ed949839958cd5d812dd939 but given

Need to include the subject of the commit:

"This is similar to commit a708fb7b1f8d ("net/mlx5e: ethtool, Add
support for EEPROM high pages query") [...]"

> all the required logic already exists in mlx4_qsfp_eeprom_params_set()
> only s/_LEN/MAX_LEN/ is needed.
> ---
>  drivers/net/ethernet/mellanox/mlx4/en_ethtool.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Code LGTM

Thanks