| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <5f735f50-301d-4995-8637-798e4907939f@loongson.cn>
Date: Mon, 8 Jul 2024 15:00:49 +0800
From: Yanteng Si <siyanteng@...ngson.cn>
To: Serge Semin <fancer.lancer@...il.com>
Cc: andrew@...n.ch, hkallweit1@...il.com, peppe.cavallaro@...com,
alexandre.torgue@...s.st.com, joabreu@...opsys.com, Jose.Abreu@...opsys.com,
chenhuacai@...nel.org, linux@...linux.org.uk, guyinggang@...ngson.cn,
netdev@...r.kernel.org, chris.chenfeiyang@...il.com, si.yanteng@...ux.dev
Subject: Re: [PATCH net-next v13 06/15] net: stmmac: dwmac-loongson: Detach
GMAC-specific platform data init
在 2024/7/7 18:40, Serge Semin 写道:
> On Sat, Jul 06, 2024 at 09:31:43PM +0800, Yanteng Si wrote:
>> 在 2024/7/5 19:53, Serge Semin 写道:
>>>> $: cat /proc/interrupts
>>>>
>>>> CPU0 CPU1
>>>> 20: 3826 12138 CPUINTC 12 IPI
>>>> 21: 15242 11791 CPUINTC 11 timer
>>>> 22: 0 0 PCH PIC 1 acpi
>>>> 28: 0 0 PCH PIC 7 loongson-alarm
>>>> 29: 0 0 PCH PIC 8 ls2x-i2c, ls2x-i2c, ls2x-i2c,
>>>> ls2x-i2c, ls2x-i2c, ls2x-i2c
>>>> 34: 7456 0 LIOINTC 10 ttyS0
>>>> 42: 1192 0 PCH PIC 17 0000:00:06.1
>>>> 43: 0 0 PCH PIC 18 ahci[0000:00:08.0]
>>>> 44: 40 0 PCH PIC 19 enp0s3f0
>>>> 45: 0 0 PCH PIC 20 enp0s3f1
>>>> 46: 1446 0 PCH PIC 21 enp0s3f2
>>>> 47: 11164 0 PCH PIC 22 xhci-hcd:usb1
>>>> 48: 338 0 PCH PIC 23 xhci-hcd:usb3
>>>> 49: 0 0 PCH PIC 24 snd_hda_intel:card0
>>>> IPI0: 117 132 LoongArch 1 Rescheduling interrupts
>>>> IPI1: 3713 12007 LoongArch 2 Function call interrupts
>>>> ERR: 1
>>>>
>>>>
>>> So, what made you thinking that the enp0s3f0, enp0s3f1 and enp0s3f2
>>> interfaces weren't working? I failed to find any immediate problem in
>>> the log.
>> I'm sorry. I made a mistake. It works fine.
>>> The driver registered eight Rx-queues (and likely eight Tx-queues).
>>> enp0s3f0 and enp0s3f2 links got up. Even the log reported that two
>>> interfaces have some network access (whatever it meant in your
>>> boot-script):
>>>
>>>> The device(7a03 and 7a13) can access the network.
>>> Yes, there is only one IRQ registered for each interface. But that's
>>> what was expected seeing you have a single MAC IRQ detected. The
>>> main question is: do the network traffic still get to flow in this
>>> case? Are you able to send/receive data over all the DMA-channels?
>> Yes, I can. in this case, enp0s3f0/1/2 can accesswww.sing.com.
>>
>>
>> Because I did another test. I turn on the checksum.
>>
>> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
>> b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
>> index 25ddd99ae112..e1cde9e0e530 100644
>> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
>> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
>> @@ -133,8 +133,8 @@ static int loongson_gmac_data(struct pci_dev *pdev,
>> /* Only channel 0 supports checksum,
>> * so turn off checksum to enable multiple channels.
>> */
>> - for (i = 1; i < CHANNEL_NUM; i++)
>> - plat->tx_queues_cfg[i].coe_unsupported = 1;
>> + // for (i = 1; i < CHANNEL_NUM; i++)
>> + // plat->tx_queues_cfg[i].coe_unsupported = 1;
>> } else {
>> plat->tx_queues_to_use = 1;
>> plat->rx_queues_to_use = 1;
>> @@ -185,8 +185,8 @@ static int loongson_gnet_data(struct pci_dev *pdev,
>> /* Only channel 0 supports checksum,
>> * so turn off checksum to enable multiple channels.
>> */
>> - for (i = 1; i < CHANNEL_NUM; i++)
>> - plat->tx_queues_cfg[i].coe_unsupported = 1;
>> + // for (i = 1; i < CHANNEL_NUM; i++)
>> + // plat->tx_queues_cfg[i].coe_unsupported = 1;
>> } else {
>> plat->tx_queues_to_use = 1;
>> plat->rx_queues_to_use = 1;
>> @@ -576,11 +576,11 @@ static int loongson_dwmac_probe(struct pci_dev *pdev,> const struct pci_device_id
>> if (ret)
>> goto err_disable_device;
>>
>> - if (ld->loongson_id == DWMAC_CORE_LOONGSON_MULTI_CH) {
>> - ret = loongson_dwmac_msi_config(pdev, plat, &res);
>> - if (ret)
>> - goto err_disable_device;
>> - }
>> + if (ld->loongson_id == DWMAC_CORE_LOONGSON_MULTI_CH) {
>> + // ret = loongson_dwmac_msi_config(pdev, plat, &res);
>> + // if (ret)
>> + // goto err_disable_device;
>> + // }
>>
>> ret = stmmac_dvr_probe(&pdev->dev, plat, &res);
>> if (ret)
>>
>> In this case, enp0s3f0/1/2 cannot access thewww.sing.com.
> Smart.) Indeed it implicitly proves that at least two channels get to
> work. Checking out the interface queues statistics (ethtool -S
> <interface>) would make it less implicit. Although something more
> comprehensive covering all the channels would be better. But it's up
> to you to decide whether you need such test implemented and performed.
OK.
[root@...hlinux ~]# ethtool -S enp0s3f2
NIC statistics:
mmc_tx_octetcount_gb: 77779
mmc_tx_framecount_gb: 765
mmc_tx_broadcastframe_g: 4
mmc_tx_multicastframe_g: 68
mmc_tx_64_octets_gb: 199
mmc_tx_65_to_127_octets_gb: 480
mmc_tx_128_to_255_octets_gb: 75
mmc_tx_256_to_511_octets_gb: 3
mmc_tx_512_to_1023_octets_gb: 1
mmc_tx_1024_to_max_octets_gb: 7
mmc_tx_unicast_gb: 693
mmc_tx_multicast_gb: 68
mmc_tx_broadcast_gb: 4
mmc_tx_underflow_error: 0
mmc_tx_singlecol_g: 0
mmc_tx_multicol_g: 0
mmc_tx_deferred: 0
mmc_tx_latecol: 0
mmc_tx_exesscol: 0
mmc_tx_carrier_error: 0
mmc_tx_octetcount_g: 77779
mmc_tx_framecount_g: 765
mmc_tx_excessdef: 0
mmc_tx_pause_frame: 0
mmc_tx_vlan_frame_g: 0
mmc_tx_oversize_g: 0
mmc_tx_lpi_usec: 0
mmc_tx_lpi_tran: 0
mmc_rx_framecount_gb: 33212
mmc_rx_octetcount_gb: 2202315
mmc_rx_octetcount_g: 2202315
mmc_rx_broadcastframe_g: 32383
mmc_rx_multicastframe_g: 216
mmc_rx_crc_error: 0
mmc_rx_align_error: 0
mmc_rx_run_error: 0
mmc_rx_jabber_error: 0
mmc_rx_undersize_g: 0
mmc_rx_oversize_g: 0
mmc_rx_64_octets_gb: 31088
mmc_rx_65_to_127_octets_gb: 1888
mmc_rx_128_to_255_octets_gb: 141
mmc_rx_256_to_511_octets_gb: 91
mmc_rx_512_to_1023_octets_gb: 2
mmc_rx_1024_to_max_octets_gb: 2
mmc_rx_unicast_g: 613
mmc_rx_length_error: 0
mmc_rx_autofrangetype: 0
mmc_rx_pause_frames: 0
mmc_rx_fifo_overflow: 0
mmc_rx_vlan_frames_gb: 0
mmc_rx_watchdog_error: 0
mmc_rx_error: 0
mmc_rx_lpi_usec: 0
mmc_rx_lpi_tran: 0
mmc_rx_discard_frames_gb: 0
mmc_rx_discard_octets_gb: 0
mmc_rx_align_err_frames: 0
mmc_rx_ipv4_gd: 920
mmc_rx_ipv4_hderr: 0
mmc_rx_ipv4_nopay: 0
mmc_rx_ipv4_frag: 0
mmc_rx_ipv4_udsbl: 0
mmc_rx_ipv4_gd_octets: 107826
mmc_rx_ipv4_hderr_octets: 0
mmc_rx_ipv4_nopay_octets: 0
mmc_rx_ipv4_frag_octets: 0
mmc_rx_ipv4_udsbl_octets: 0
mmc_rx_ipv6_gd_octets: 17360
mmc_rx_ipv6_hderr_octets: 0
mmc_rx_ipv6_nopay_octets: 0
mmc_rx_ipv6_gd: 219
mmc_rx_ipv6_hderr: 0
mmc_rx_ipv6_nopay: 0
mmc_rx_udp_gd: 571
mmc_rx_udp_err: 0
mmc_rx_tcp_gd: 337
mmc_rx_tcp_err: 0
mmc_rx_icmp_gd: 231
mmc_rx_icmp_err: 0
mmc_rx_udp_gd_octets: 65149
mmc_rx_udp_err_octets: 0
mmc_rx_tcp_gd_octets: 23525
mmc_rx_tcp_err_octets: 0
mmc_rx_icmp_gd_octets: 8880
mmc_rx_icmp_err_octets: 0
mmc_sgf_pass_fragment_cntr: 0
mmc_sgf_fail_fragment_cntr: 0
mmc_tx_fpe_fragment_cntr: 0
mmc_tx_hold_req_cntr: 0
mmc_tx_gate_overrun_cntr: 0
mmc_rx_packet_assembly_err_cntr: 0
mmc_rx_packet_smd_err_cntr: 0
mmc_rx_packet_assembly_ok_cntr: 0
mmc_rx_fpe_fragment_cntr: 0
tx_underflow: 0
tx_carrier: 0
tx_losscarrier: 0
vlan_tag: 0
tx_deferred: 0
tx_vlan: 0
tx_jabber: 0
tx_frame_flushed: 0
tx_payload_error: 0
tx_ip_header_error: 0
rx_desc: 0
sa_filter_fail: 0
overflow_error: 0
ipc_csum_error: 0
rx_collision: 0
rx_crc_errors: 0
dribbling_bit: 0
rx_length: 0
rx_mii: 0
rx_multicast: 0
rx_gmac_overflow: 0
rx_watchdog: 0
da_rx_filter_fail: 0
sa_rx_filter_fail: 0
rx_missed_cntr: 0
rx_overflow_cntr: 0
rx_vlan: 0
rx_split_hdr_pkt_n: 0
tx_undeflow_irq: 0
tx_process_stopped_irq: 0
tx_jabber_irq: 0
rx_overflow_irq: 0
rx_buf_unav_irq: 0
rx_process_stopped_irq: 0
rx_watchdog_irq: 0
tx_early_irq: 0
fatal_bus_error_irq: 0
rx_early_irq: 0
threshold: 1
irq_receive_pmt_irq_n: 0
mmc_tx_irq_n: 0
mmc_rx_irq_n: 0
mmc_rx_csum_offload_irq_n: 0
irq_tx_path_in_lpi_mode_n: 0
irq_tx_path_exit_lpi_mode_n: 0
irq_rx_path_in_lpi_mode_n: 0
irq_rx_path_exit_lpi_mode_n: 0
phy_eee_wakeup_error_n: 0
ip_hdr_err: 0
ip_payload_err: 0
ip_csum_bypassed: 0
ipv4_pkt_rcvd: 920
ipv6_pkt_rcvd: 219
no_ptp_rx_msg_type_ext: 1139
ptp_rx_msg_type_sync: 0
ptp_rx_msg_type_follow_up: 0
ptp_rx_msg_type_delay_req: 0
ptp_rx_msg_type_delay_resp: 0
ptp_rx_msg_type_pdelay_req: 0
ptp_rx_msg_type_pdelay_resp: 0
ptp_rx_msg_type_pdelay_follow_up: 0
ptp_rx_msg_type_announce: 0
ptp_rx_msg_type_management: 0
ptp_rx_msg_pkt_reserved_type: 0
ptp_frame_type: 0
ptp_ver: 0
timestamp_dropped: 0
av_pkt_rcvd: 0
av_tagged_pkt_rcvd: 0
vlan_tag_priority_val: 0
l3_filter_match: 0
l4_filter_match: 0
l3_l4_filter_no_match: 0
irq_pcs_ane_n: 0
irq_pcs_link_n: 0
irq_rgmii_n: 0
mtl_tx_status_fifo_full: 0
mtl_tx_fifo_not_empty: 0
mmtl_fifo_ctrl: 0
mtl_tx_fifo_read_ctrl_write: 0
mtl_tx_fifo_read_ctrl_wait: 0
mtl_tx_fifo_read_ctrl_read: 0
mtl_tx_fifo_read_ctrl_idle: 0
mac_tx_in_pause: 0
mac_tx_frame_ctrl_xfer: 0
mac_tx_frame_ctrl_idle: 0
mac_tx_frame_ctrl_wait: 0
mac_tx_frame_ctrl_pause: 0
mac_gmii_tx_proto_engine: 0
mtl_rx_fifo_fill_level_full: 0
mtl_rx_fifo_fill_above_thresh: 0
mtl_rx_fifo_fill_below_thresh: 0
mtl_rx_fifo_fill_level_empty: 0
mtl_rx_fifo_read_ctrl_flush: 0
mtl_rx_fifo_read_ctrl_read_data: 0
mtl_rx_fifo_read_ctrl_status: 0
mtl_rx_fifo_read_ctrl_idle: 0
mtl_rx_fifo_ctrl_active: 0
mac_rx_frame_ctrl_fifo: 0
mac_gmii_rx_proto_engine: 0
mtl_est_cgce: 0
mtl_est_hlbs: 0
mtl_est_hlbf: 0
mtl_est_btre: 0
mtl_est_btrlm: 0
rx_pkt_n: 33212
rx_normal_irq_n: 33004
tx_pkt_n: 764
tx_normal_irq_n: 33
tx_clean: 651
tx_set_ic_bit: 33
tx_tso_frames: 0
tx_tso_nfrags: 0
normal_irq_n: 33037
napi_poll: 33655
q0_tx_pkt_n: 512
q0_tx_irq_n: 26
q1_tx_pkt_n: 15
q1_tx_irq_n: 0
q2_tx_pkt_n: 33
q2_tx_irq_n: 1
q3_tx_pkt_n: 9
q3_tx_irq_n: 0
q4_tx_pkt_n: 20
q4_tx_irq_n: 0
q5_tx_pkt_n: 9
q5_tx_irq_n: 0
q6_tx_pkt_n: 134
q6_tx_irq_n: 5
q7_tx_pkt_n: 32
q7_tx_irq_n: 1
q0_rx_pkt_n: 33212
q0_rx_irq_n: 33004
q1_rx_pkt_n: 0
q1_rx_irq_n: 0
q2_rx_pkt_n: 0
q2_rx_irq_n: 0
q3_rx_pkt_n: 0
q3_rx_irq_n: 0
q4_rx_pkt_n: 0
q4_rx_irq_n: 0
q5_rx_pkt_n: 0
q5_rx_irq_n: 0
q6_rx_pkt_n: 0
q6_rx_irq_n: 0
q7_rx_pkt_n: 0
q7_rx_irq_n: 0
[root@...hlinux ~]#
Thanks,
Yanteng
Powered by blists - more mailing lists