netdev - Re: [net-next,PATCH] dt-bindings: net: realtek,rtl82xx: Document RTL8211F LED support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240708205856.GA3874098-robh@kernel.org>
Date: Mon, 8 Jul 2024 14:58:56 -0600
From: Rob Herring <robh@...nel.org>
To: Marek Vasut <marex@...x.de>
Cc: netdev@...r.kernel.org, kernel@...electronics.com,
	"David S. Miller" <davem@...emloft.net>,
	Andrew Lunn <andrew@...n.ch>, Conor Dooley <conor+dt@...nel.org>,
	Eric Dumazet <edumazet@...gle.com>,
	Florian Fainelli <f.fainelli@...il.com>,
	Heiner Kallweit <hkallweit1@...il.com>,
	Jakub Kicinski <kuba@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Paolo Abeni <pabeni@...hat.com>, devicetree@...r.kernel.org
Subject: Re: [net-next,PATCH] dt-bindings: net: realtek,rtl82xx: Document
 RTL8211F LED support

On Fri, Jul 05, 2024 at 11:51:46PM +0200, Marek Vasut wrote:
> The RTL8211F PHY does support LED configuration, document support
> for LEDs in the binding document.
> 
> Signed-off-by: Marek Vasut <marex@...x.de>
> ---
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Andrew Lunn <andrew@...n.ch>
> Cc: Conor Dooley <conor+dt@...nel.org>
> Cc: Eric Dumazet <edumazet@...gle.com>
> Cc: Florian Fainelli <f.fainelli@...il.com>
> Cc: Heiner Kallweit <hkallweit1@...il.com>
> Cc: Jakub Kicinski <kuba@...nel.org>
> Cc: Krzysztof Kozlowski <krzk+dt@...nel.org>
> Cc: Paolo Abeni <pabeni@...hat.com>
> Cc: Rob Herring <robh@...nel.org>
> Cc: devicetree@...r.kernel.org
> Cc: netdev@...r.kernel.org
> ---
>  .../devicetree/bindings/net/realtek,rtl82xx.yaml   | 14 +++++++++++---
>  1 file changed, 11 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/realtek,rtl82xx.yaml b/Documentation/devicetree/bindings/net/realtek,rtl82xx.yaml
> index 18ee72f5c74a8..28c048368073b 100644
> --- a/Documentation/devicetree/bindings/net/realtek,rtl82xx.yaml
> +++ b/Documentation/devicetree/bindings/net/realtek,rtl82xx.yaml
> @@ -14,9 +14,6 @@ maintainers:
>  description:
>    Bindings for Realtek RTL82xx PHYs
>  
> -allOf:
> -  - $ref: ethernet-phy.yaml#
> -
>  properties:
>    compatible:
>      enum:
> @@ -54,6 +51,17 @@ properties:
>  
>  unevaluatedProperties: false
>  
> +allOf:
> +  - $ref: ethernet-phy.yaml#
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: ethernet-phy-id001c.c916
> +    then:
> +      properties:
> +        leds: true

This has no effect. 'leds' node is already allowed with the ref to 
ethernet-phy.yaml. I suppose you could negate the if and then, but I'm 
not really that worried if someone defines LEDs for a device with no 
LEDs. 

Rob