netdev - Re: [PATCH net v2 1/4] ipv4: fix source address selection with route leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8d993975-e637-4594-8dd8-b725111705e8@6wind.com>
Date: Mon, 8 Jul 2024 23:27:05 +0200
From: Nicolas Dichtel <nicolas.dichtel@...nd.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: David Ahern <dsahern@...nel.org>, "David S . Miller"
 <davem@...emloft.net>, Paolo Abeni <pabeni@...hat.com>,
 Eric Dumazet <edumazet@...gle.com>, netdev@...r.kernel.org,
 stable@...r.kernel.org
Subject: Re: [PATCH net v2 1/4] ipv4: fix source address selection with route
 leak

Le 08/07/2024 à 22:32, Jakub Kicinski a écrit :
> On Mon, 8 Jul 2024 20:13:56 +0200 Nicolas Dichtel wrote:
>>> long line length. separate setting the value:
>>>
>>> 		struct net_device *l3mdev;
>>>
>>> 		l3mdev = dev_get_by_index_rcu(net, fl4->flowi4_l3mdev);  
>> The checkpatch limit is 100-column.
>> If the 80-column limit needs to be enforced in net/, maybe a special case should
>> be added in checkpatch.
> 
> That'd be great. I'm pretty unsuccessful to at getting my patches
> accepted to checkpatch and get_maintainers so I gave up.
Oh, ok :/

> But I never tried with the line length limit.
Why not (: