netdev - Re: [PATCH net-next 2/3] ice: Implement driver functionality to dump fec statistics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <59036dfd-d008-0d14-0ae5-b4e258147777@intel.com>
Date: Mon, 8 Jul 2024 15:46:05 -0700
From: Tony Nguyen <anthony.l.nguyen@...el.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: <davem@...emloft.net>, <pabeni@...hat.com>, <edumazet@...gle.com>,
	<netdev@...r.kernel.org>, Anil Samal <anil.samal@...el.com>, Simon Horman
	<horms@...nel.org>, Jesse Brandeburg <jesse.brandeburg@...el.com>, "Pucha
 Himasekhar Reddy" <himasekharx.reddy.pucha@...el.com>
Subject: Re: [PATCH net-next 2/3] ice: Implement driver functionality to dump
 fec statistics

On 7/3/2024 7:55 PM, Jakub Kicinski wrote:
> On Tue,  2 Jul 2024 11:07:06 -0700 Tony Nguyen wrote:
>> +	pf = np->vsi->back;
>> +	hw = &pf->hw;
>> +	pi = np->vsi->port_info;
>> +
>> +	if (!hw || !pi)
>> +		return;
> 
> nit: hw can't possibly be NULL, it's pf + offset, even if pf is null hw
> won't be; maybe also combine the pi check with the type check below?
> to make it look less like defensive programming..
> 
> next patch has the same isse

...

>> +	/* Get FEC correctable, uncorrectable counter */
>> +	err = ice_get_port_fec_stats(hw, port_topology.pcs_quad_select,
>> +				     port_topology.pcs_port, fec_stats);
>> +	if (err) {
>> +		netdev_info(netdev, "FEC stats get failed Lport %d Err %d\n",
>> +			    pi->lport, err);
>> +	}
> 
> unnecessary brackets

Hi Jakub,

Anil sent his update to iwl-next[1] so will get these changed for v2.

Thanks,
Tony

[1] 
https://lore.kernel.org/intel-wired-lan/20240708144833.1337075-1-anil.samal@intel.com/T/#t