netdev - Re: [PATCH -next] gss_krb5: Fix the error handling path for crypto_sync_skcipher

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240708091004.GH1481495@kernel.org>
Date: Mon, 8 Jul 2024 10:10:04 +0100
From: Simon Horman <horms@...nel.org>
To: Gaosheng Cui <cuigaosheng1@...wei.com>
Cc: trondmy@...nel.org, anna@...nel.org, chuck.lever@...cle.com,
	jlayton@...nel.org, neilb@...e.de, kolga@...app.com,
	Dai.Ngo@...cle.com, tom@...pey.com, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	steved@...hat.com, kwc@...i.umich.edu, linux-nfs@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH -next] gss_krb5: Fix the error handling path for
 crypto_sync_skcipher_setkey

On Sat, Jul 06, 2024 at 02:50:08PM +0800, Gaosheng Cui wrote:
> If we fail to call crypto_sync_skcipher_setkey, we should free the
> memory allocation for cipher, replace err_return with err_free_cipher
> to free the memory of cipher.
> 
> Fixes: 4891f2d008e4 ("gss_krb5: import functionality to derive keys into the kernel")
> Signed-off-by: Gaosheng Cui <cuigaosheng1@...wei.com>

Reviewed-by: Simon Horman <horms@...nel.org>