netdev - Re: [PATCH net-next v2] net: tls: Pass union tls_crypto_context pointer to memzero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240708201514.567883e4@kernel.org>
Date: Mon, 8 Jul 2024 20:15:14 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Simon Horman <horms@...nel.org>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Boris Pismenny
 <borisp@...dia.com>, John Fastabend <john.fastabend@...il.com>, Przemek
 Kitszel <przemyslaw.kitszel@...el.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2] net: tls: Pass union tls_crypto_context
 pointer to memzero_explicit

On Mon, 08 Jul 2024 08:27:19 +0100 Simon Horman wrote:
> Pass union tls_crypto_context pointer, rather than struct
> tls_crypto_info pointer, to memzero_explicit().
> 
> The address of the pointer is the same before and after.
> But the new construct means that the size of the dereferenced pointer type
> matches the size being zeroed. Which aids static analysis.
> 
> As reported by Smatch:
> 
>   .../tls_main.c:842 do_tls_setsockopt_conf() error: memzero_explicit() 'crypto_info' too small (4 vs 56)
> 
> No functional change intended.
> Compile tested only.
> 
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> Signed-off-by: Simon Horman <horms@...nel.org>

Reviewed-by: Jakub Kicinski <kuba@...nel.org>