[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Zo1U4dX-kGcm0hHA@google.com>
Date: Tue, 9 Jul 2024 17:18:57 +0200
From: "Günther Noack" <gnoack@...gle.com>
To: Tahera Fahimi <fahimitahera@...il.com>
Cc: mic@...ikod.net, paul@...l-moore.com, jmorris@...ei.org, serge@...lyn.com,
linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org,
bjorn3_gh@...tonmail.com, jannh@...gle.com, outreachy@...ts.linux.dev,
netdev@...r.kernel.org
Subject: Re: [PATCH v1 2/2] Landlock: Signal scoping tests
On Fri, Jul 05, 2024 at 03:21:43PM -0600, Tahera Fahimi wrote:
> Signed-off-by: Tahera Fahimi <fahimitahera@...il.com>
> ---
> .../testing/selftests/landlock/ptrace_test.c | 216 ++++++++++++++++++
> 1 file changed, 216 insertions(+)
>
> diff --git a/tools/testing/selftests/landlock/ptrace_test.c b/tools/testing/selftests/landlock/ptrace_test.c
> index a19db4d0b3bd..e092b67f8b67 100644
> --- a/tools/testing/selftests/landlock/ptrace_test.c
> +++ b/tools/testing/selftests/landlock/ptrace_test.c
> [...]
> +static void scope_signal_handler(int sig, siginfo_t *info, void *ucontext)
> +{
> + if (sig == SIGHUP || sig == SIGURG || sig == SIGTSTP || sig == SIGTRAP)
> + signaled = 1;
> +
> + // signal process group
> + //kill(-(t->pid), SIGKILL);
There is commented-out code like this in various places in this patch.
I am pretty sure that scripts/checkpatch.pl should flag that.
See https://docs.kernel.org/dev-tools/checkpatch.html
and https://docs.kernel.org/process/submitting-patches.html#style-check-your-changes
I personally just keep a checklist of things to remember before sending a patch.
(rebase as needed, clang-format -i (for Landlock files), run tests, check commit
metadata, git format-patch with -v and --cover-letter, scripts/checkpatch.pl,
edit cover letter, git send-email)
—Günther
Powered by blists - more mailing lists