netdev - Re: [PATCH v2 2/2] net: stmmac: dwmac-qcom-ethqos: add support for emac4 on qcs9100 platforms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2427a6fe-834c-432c-8e5a-4981354645d2@lunn.ch>
Date: Tue, 9 Jul 2024 17:33:04 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Andrew Halaney <ahalaney@...hat.com>
Cc: Tengfei Fan <quic_tengfan@...cinc.com>, Vinod Koul <vkoul@...nel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Bhupesh Sharma <bhupesh.sharma@...aro.org>,
	Alexandre Torgue <alexandre.torgue@...s.st.com>,
	Giuseppe Cavallaro <peppe.cavallaro@...com>,
	Jose Abreu <joabreu@...opsys.com>,
	Maxime Coquelin <mcoquelin.stm32@...il.com>, kernel@...cinc.com,
	netdev@...r.kernel.org, linux-arm-msm@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-stm32@...md-mailman.stormreply.com,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 2/2] net: stmmac: dwmac-qcom-ethqos: add support for
 emac4 on qcs9100 platforms

On Tue, Jul 09, 2024 at 09:40:55AM -0500, Andrew Halaney wrote:
> These patches are for netdev, so you need to follow the netdev
> rules, i.e. the subject should be have [PATCH net-next] in it, etc as
> documented over here:
> 
>     https://docs.kernel.org/process/maintainer-netdev.html#tl-dr
> 
> On Tue, Jul 09, 2024 at 10:13:18PM GMT, Tengfei Fan wrote:
> > QCS9100 uses EMAC version 4, add the relevant defines, rename the
> > has_emac3 switch to has_emac_ge_3 (has emac greater-or-equal than 3)
> > and add the new compatible.
> 
> This blurb isn't capturing what's done in this change, please make it
> reflect the patch.

Hi Tengfei

If i remember correctly, there was a similar comment made to one of
the patches in the huge v1 series.

The commit messages are very important, just as important as the code
itself. Please review them all and fixup issues like this before you
repost.

    Andrew

---
pw-bot: cr