netdev - Re: [PATCH -next] rxrpc: Fix the error handling path in rxkad_init_connection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240709175834.GN346094@kernel.org>
Date: Tue, 9 Jul 2024 18:58:34 +0100
From: Simon Horman <horms@...nel.org>
To: Gaosheng Cui <cuigaosheng1@...wei.com>
Cc: dhowells@...hat.com, marc.dionne@...istor.com, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	linux-afs@...ts.infradead.org, netdev@...r.kernel.org
Subject: Re: [PATCH -next] rxrpc: Fix the error handling path in
 rxkad_init_connection_security

On Tue, Jul 09, 2024 at 06:49:10PM +0800, Gaosheng Cui wrote:
> If security_level of rxrpc_connection is invalid, ci should be freed
> by crypto_free_sync_skcipher, replace error with error_ci to fix the
> memory leak.
> 
> Fixes: 17926a79320a ("[AF_RXRPC]: Provide secure RxRPC sockets for use by userspace and kernel both")
> Signed-off-by: Gaosheng Cui <cuigaosheng1@...wei.com>

Reviewed-by: Simon Horman <horms@...nel.org>

As an aside, the BUG() in the middle of rxkad_init_connection_security()
is a bit of a surprise.