netdev - RE: [PATCH net v3 1/1] ethtool: netlink: do not return SQI value if link is down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BL0PR11MB291373114256CDD26A8019A8E7DB2@BL0PR11MB2913.namprd11.prod.outlook.com>
Date: Tue, 9 Jul 2024 18:03:24 +0000
From: <Woojung.Huh@...rochip.com>
To: <o.rempel@...gutronix.de>, <mkubecek@...e.cz>, <davem@...emloft.net>,
	<edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>,
	<jiri@...nulli.us>, <vladimir.oltean@....com>, <andrew@...n.ch>,
	<Arun.Ramadoss@...rochip.com>
CC: <kernel@...gutronix.de>, <netdev@...r.kernel.org>,
	<UNGLinuxDriver@...rochip.com>, <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH net v3 1/1] ethtool: netlink: do not return SQI value if
 link is down

> -----Original Message-----
> From: Oleksij Rempel <o.rempel@...gutronix.de>
> Sent: Tuesday, July 9, 2024 2:20 AM
> To: Michal Kubecek <mkubecek@...e.cz>; David S. Miller <davem@...emloft.net>;
> Eric Dumazet <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo
> Abeni <pabeni@...hat.com>; Jiri Pirko <jiri@...nulli.us>; Vladimir Oltean
> <vladimir.oltean@....com>; Andrew Lunn <andrew@...n.ch>; Arun Ramadoss -
> I17769 <Arun.Ramadoss@...rochip.com>; Woojung Huh - C21699
> <Woojung.Huh@...rochip.com>
> Cc: Oleksij Rempel <o.rempel@...gutronix.de>; kernel@...gutronix.de;
> netdev@...r.kernel.org; UNGLinuxDriver <UNGLinuxDriver@...rochip.com>;
> linux-kernel@...r.kernel.org
> Subject: [PATCH net v3 1/1] ethtool: netlink: do not return SQI value if
> link is down
> 
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
> 
> Do not attach SQI value if link is down. "SQI values are only valid if
> link-up condition is present" per OpenAlliance specification of
> 100Base-T1 Interoperability Test suite [1]. The same rule would apply
> for other link types.
> 
> [1] https://opensig.org/automotive-ethernet-specifications/#
> 
> Fixes: 806602191592 ("ethtool: provide UAPI for PHY Signal Quality Index
> (SQI)")
> Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de>
> Reviewed-by: Andrew Lunn <andrew@...n.ch>
> ---

Reviewed-by: Woojung Huh <woojung.huh@...rochip.com>

Thanks.
Woojung