netdev - Re: [PATCH] vdpa/mlx5: Add the support of set mac address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACLfguUYny6-1cYABsGS+qtdzO+MKp3O09t_gt-bMM4JgdpZqA@mail.gmail.com>
Date: Tue, 9 Jul 2024 15:35:13 +0800
From: Cindy Lu <lulu@...hat.com>
To: Ratheesh Kannoth <rkannoth@...vell.com>
Cc: dtatulea@...dia.com, mst@...hat.com, jasowang@...hat.com, parav@...dia.com, 
	sgarzare@...hat.com, netdev@...r.kernel.org, 
	virtualization@...ts.linux-foundation.org, linux-kernel@...r.kernel.org, 
	kvm@...r.kernel.org
Subject: Re: [PATCH] vdpa/mlx5: Add the support of set mac address

On Tue, 9 Jul 2024 at 12:56, Ratheesh Kannoth <rkannoth@...vell.com> wrote:
>
> On 2024-07-08 at 12:25:49, Cindy Lu (lulu@...hat.com) wrote:
> > +static int mlx5_vdpa_set_attr_mac(struct vdpa_mgmt_dev *v_mdev,
> > +                               struct vdpa_device *dev,
> > +                               const struct vdpa_dev_set_config *add_config)
> > +{
> > +     struct mlx5_vdpa_dev *mvdev = to_mvdev(dev);
> > +     struct mlx5_vdpa_net *ndev = to_mlx5_vdpa_ndev(mvdev);
> > +     struct mlx5_core_dev *mdev = mvdev->mdev;
> > +     struct virtio_net_config *config = &ndev->config;
> > +     int err;
> > +     struct mlx5_core_dev *pfmdev;
> nit: reverse xmas tree; may be, split assigment and definition.
>
Thanks, Will change this
Thanks
cindy
> >
>