netdev - Re: [PATCH V2] test/vsock: add install target

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e6oxt6gw36mhv54qbgc2bihcaym2xrquxtsjhyvm2u7wj76nu5@zneaxujp6oei>
Date: Wed, 10 Jul 2024 14:43:46 +0200
From: Stefano Garzarella <sgarzare@...hat.com>
To: "Peng Fan (OSS)" <peng.fan@....nxp.com>
Cc: virtualization@...ts.linux.dev, netdev@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Peng Fan <peng.fan@....com>
Subject: Re: [PATCH V2] test/vsock: add install target

On Wed, Jul 10, 2024 at 08:27:28PM GMT, Peng Fan (OSS) wrote:
>From: Peng Fan <peng.fan@....com>
>
>Add install target for vsock to make Yocto easy to install the images.
>
>Signed-off-by: Peng Fan <peng.fan@....com>
>---

LGTM! This is a net-next material, so next time better to specify it 
(e.g. [PATCH net-next]).

If not queued within a week, please resend specifying net-next.

Reviewed-by: Stefano Garzarella <sgarzare@...hat.com>

>
>V2:
> Use VSOCK_INSTALL_PATH, drop INSTALL_PATH
>
> tools/testing/vsock/Makefile | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
>diff --git a/tools/testing/vsock/Makefile b/tools/testing/vsock/Makefile
>index a7f56a09ca9f..6e0b4e95e230 100644
>--- a/tools/testing/vsock/Makefile
>+++ b/tools/testing/vsock/Makefile
>@@ -13,3 +13,16 @@ CFLAGS += -g -O2 -Werror -Wall -I. -I../../include -I../../../usr/include -Wno-p
> clean:
> 	${RM} *.o *.d vsock_test vsock_diag_test vsock_perf vsock_uring_test
> -include *.d
>+
>+VSOCK_INSTALL_PATH ?=
>+
>+install: all
>+ifdef VSOCK_INSTALL_PATH
>+	mkdir -p $(VSOCK_INSTALL_PATH)
>+	install -m 744 vsock_test $(VSOCK_INSTALL_PATH)
>+	install -m 744 vsock_perf $(VSOCK_INSTALL_PATH)
>+	install -m 744 vsock_diag_test $(VSOCK_INSTALL_PATH)
>+	install -m 744 vsock_uring_test $(VSOCK_INSTALL_PATH)
>+else
>+	$(error Error: set VSOCK_INSTALL_PATH to use install)
>+endif
>-- 
>2.37.1
>