netdev - [PATCH bpf-next] bpf: Remove tst_run from lwt_seg6local_prog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240710141631.FbmHcQaX@linutronix.de>
Date: Wed, 10 Jul 2024 16:16:31 +0200
From: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To: Martin KaFai Lau <martin.lau@...ux.dev>
Cc: syzbot <syzbot+608a2acde8c5a101d07d@...kaller.appspotmail.com>,
	netdev@...r.kernel.org, bpf@...r.kernel.org, andrii@...nel.org,
	ast@...nel.org, daniel@...earbox.net, davem@...emloft.net,
	dsahern@...nel.org, eddyz87@...il.com, edumazet@...gle.com,
	haoluo@...gle.com, john.fastabend@...il.com, jolsa@...nel.org,
	kpsingh@...nel.org, kuba@...nel.org, pabeni@...hat.com,
	sdf@...ichev.me, sdf@...gle.com, song@...nel.org,
	syzkaller-bugs@...glegroups.com, yonghong.song@...ux.dev,
	Thomas Gleixner <tglx@...utronix.de>,
	Mathieu Xhonneux <m.xhonneux@...il.com>,
	David Lebrun <dlebrun@...gle.com>
Subject: [PATCH bpf-next] bpf: Remove tst_run from lwt_seg6local_prog_ops.

The syzbot reported that the lwt_seg6 related BPF ops can be invoked
via bpf_test_run() without without entering input_action_end_bpf()
first.

Martin KaFai Lau said that self test for BPF_PROG_TYPE_LWT_SEG6LOCAL
probably didn't work since it was introduced in commit 04d4b274e2a
("ipv6: sr: Add seg6local action End.BPF"). The reason is that the
per-CPU variable seg6_bpf_srh_states::srh is never assigned in the self
test case but each BPF function expects it.

Remove test_run for BPF_PROG_TYPE_LWT_SEG6LOCAL.

Suggested-by: Martin KaFai Lau <martin.lau@...ux.dev>
Reported-by: syzbot+608a2acde8c5a101d07d@...kaller.appspotmail.com
Fixes: d1542d4ae4df ("seg6: Use nested-BH locking for seg6_bpf_srh_states.")
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
---
 net/core/filter.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/net/core/filter.c b/net/core/filter.c
index d767880c276d9..4cf1d34f76172 100644
--- a/net/core/filter.c
+++ b/net/core/filter.c
@@ -11053,7 +11053,6 @@ const struct bpf_verifier_ops lwt_seg6local_verifier_ops = {
 };
 
 const struct bpf_prog_ops lwt_seg6local_prog_ops = {
-	.test_run		= bpf_prog_test_run_skb,
 };
 
 const struct bpf_verifier_ops cg_sock_verifier_ops = {
-- 
2.45.2