netdev - Re: [PATCH net-next] net: do not inline rtnl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANn89iLJWwQe-iTTMWenk9xVEUtuzJVh8X0jW0fBrijUan_N9g@mail.gmail.com>
Date: Wed, 10 Jul 2024 08:08:11 -0700
From: Eric Dumazet <edumazet@...gle.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: "David S . Miller" <davem@...emloft.net>, Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org, 
	eric.dumazet@...il.com
Subject: Re: [PATCH net-next] net: do not inline rtnl_calcit()

On Tue, Jul 9, 2024 at 6:23 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Tue,  9 Jul 2024 23:08:15 +0000 Eric Dumazet wrote:
> > -static u32 rtnl_calcit(struct sk_buff *skb, struct nlmsghdr *nlh)
> > +static noinline_for_stack u32 rtnl_calcit(struct sk_buff *skb,
> > +                                       struct nlmsghdr *nlh)
>
> We only look at a single attribute - IFLA_EXT_MASK. We can change the
> tb size to IFLA_EXT_MASK + 1 and pass IFLA_EXT_MASK as max_attr to
> parse. Parsing the other attrs is pointless, anyway.
>
> Or possibly just walk the attrs with nla_for_each_attr_type() without
> parsing at all.

I certainly can do this, thanks for the suggestion.