netdev - Re: [PATCH] net: linearizing skb when downgrade gso

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zo8T/ZE+fyGaPZaE@gondor.apana.org.au>
Date: Thu, 11 Jul 2024 11:06:37 +1200
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Willem de Bruijn <willemdebruijn.kernel@...il.com>
Cc: Fred Li <dracodingfly@...il.com>, aleksander.lobakin@...el.com,
	andrii@...nel.org, ast@...nel.org, bpf@...r.kernel.org,
	daniel@...earbox.net, davem@...emloft.net, edumazet@...gle.com,
	haoluo@...gle.com, hawk@...nel.org, john.fastabend@...il.com,
	jolsa@...nel.org, kpsingh@...nel.org, kuba@...nel.org,
	linux-kernel@...r.kernel.org, linux@...ssschuh.net,
	martin.lau@...ux.dev, mkhalfella@...estorage.com, nbd@....name,
	netdev@...r.kernel.org, pabeni@...hat.com, sashal@...nel.org,
	sdf@...gle.com, song@...nel.org, yonghong.song@...ux.dev
Subject: Re: [PATCH] net: linearizing skb when downgrade gso_size

On Tue, Jul 09, 2024 at 05:29:59PM -0400, Willem de Bruijn wrote:
>
> This is an unfortunate feature, but already exists.
> 
> It decreases gso_size to account for tunnel headers.

Growing the tunnel header is totally fine.  But you should not
decrease gso_size because of that.  Instead the correct course
of action is to drop the packet and generate an ICMP if it no
longer fits the MTU.

A router that resegments a TCP packet at the TCP-level (not IP)
is brain-dead.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt