netdev - Re: [net-next PATCH v4 00/15] eth: fbnic: Add network driver for Meta Platforms Host Network Interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKgT0UcKFbFSWnqoHKPz1P8yZDvqX2wVSgHE86TvSaP8bo7G3Q@mail.gmail.com>
Date: Wed, 10 Jul 2024 16:51:57 -0700
From: Alexander Duyck <alexander.duyck@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, Bjorn Helgaas <bhelgaas@...gle.com>, linux-pci@...r.kernel.org, 
	Russell King <linux@...linux.org.uk>, Sanman Pradhan <sanmanpradhan@...a.com>, 
	Andrew Lunn <andrew@...n.ch>, Alexander Duyck <alexanderduyck@...com>, davem@...emloft.net, 
	pabeni@...hat.com, edumazet@...gle.com, kernel-team@...a.com
Subject: Re: [net-next PATCH v4 00/15] eth: fbnic: Add network driver for Meta
 Platforms Host Network Interface

On Wed, Jul 10, 2024 at 11:12 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Tue, 09 Jul 2024 10:28:30 -0700 Alexander Duyck wrote:
> > This patchest includes the necessary patches to enable basic Tx and Rx over
> > the Meta Platforms Host Network Interface. To do this we introduce a new
> > driver and driver directories in the form of
> > "drivers/net/ethernet/meta/fbnic".
> >
> > The NIC itself is fairly simplistic. As far as speeds we support 25Gb,
> > 50Gb, and 100Gb and we are mostly focused on speeds and feeds. As far as
> > future patch sets we will be supporting the basic Rx/Tx offloads such as
> > header/payload data split, TSO, checksum, and timestamp offloads. We have
> > access to the MAC and PCS from the NIC, however the PHY and QSFP are hidden
> > behind a FW layer as it is shared between 4 slices and the BMC.
> >
> > Due to submission limits the the general plan to submit a minimal driver
> > for now almost equivilent to a UEFI driver in functionality, and then
> > follow up over the coming months enabling additional offloads and enabling
> > more features for the device.
>
> cocci says:
>
> drivers/net/ethernet/meta/fbnic/fbnic_irq.c:42:7-27: WARNING: Threaded IRQ with no primary handler requested without IRQF_ONESHOT (unless it is nested IRQ)

Ah, okay. Looks like I should have set the IRQF_ONESHOT flag as that
was the intended use.