netdev - Re: [PATCH net-next v3] tg3: Remove residual error handling in tg3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALs4sv20_K0P_Ach=_kZ1jDZHKXvvcNBxatF9sP0iHRNku2OMQ@mail.gmail.com>
Date: Wed, 10 Jul 2024 10:23:15 +0530
From: Pavan Chebbi <pavan.chebbi@...adcom.com>
To: Nikita Kiryushin <kiryushin@...ud.ru>
Cc: Michael Chan <mchan@...adcom.com>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	"Rafael J. Wysocki" <rjw@...ysocki.net>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, 
	lvc-project@...uxtesting.org, Michael Chan <michael.chan@...adcom.com>
Subject: Re: [PATCH net-next v3] tg3: Remove residual error handling in tg3_suspend

On Tue, Jul 9, 2024 at 10:24 PM Nikita Kiryushin <kiryushin@...ud.ru> wrote:
>
> As of now, tg3_power_down_prepare always ends with success, but
> the error handling code from former tg3_set_power_state call is still here.
>
> This code became unreachable in commit c866b7eac073 ("tg3: Do not use
> legacy PCI power management").
>
> Remove (now unreachable) error handling code for simplification and change
> tg3_power_down_prepare to a void function as its result is no more checked.
>
> Signed-off-by: Nikita Kiryushin <kiryushin@...ud.ru>
> Reviewed-by: Michael Chan <michael.chan@...adcom.com>
> ---
> Resubmitted tha patch as it was applied to wrong tree and then
> reverted in commit 72076fc9fe60

I am not sure I understand this patch, commit d72b735712e65, which is
the same patch, is already applied, right?

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4209 bytes)