netdev - Re: [PATCH net 8/8] ice: xsk: fix txq interrupt mapping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20240710055200.GA3213393@maili.marvell.com>
Date: Wed, 10 Jul 2024 11:22:00 +0530
From: Ratheesh Kannoth <rkannoth@...vell.com>
To: Tony Nguyen <anthony.l.nguyen@...el.com>
CC: <davem@...emloft.net>, <kuba@...nel.org>, <pabeni@...hat.com>,
        <edumazet@...gle.com>, <netdev@...r.kernel.org>,
        Maciej Fijalkowski
	<maciej.fijalkowski@...el.com>,
        <magnus.karlsson@...el.com>, <aleksander.lobakin@...el.com>,
        <ast@...nel.org>, <daniel@...earbox.net>, <hawk@...nel.org>,
        <john.fastabend@...il.com>, <bpf@...r.kernel.org>,
        Shannon
 Nelson <shannon.nelson@....com>,
        Chandan Kumar Rout <chandanx.rout@...el.com>
Subject: Re: [PATCH net 8/8] ice: xsk: fix txq interrupt mapping

On 2024-07-09 at 03:44:14, Tony Nguyen (anthony.l.nguyen@...el.com) wrote:
> From: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
>
>  {
>  	u16 reg_idx = q_vector->reg_idx;
>  	struct ice_pf *pf = vsi->back;
>  	struct ice_hw *hw = &pf->hw;
> -	struct ice_tx_ring *tx_ring;
> -	struct ice_rx_ring *rx_ring;
> +	int q, _qid = qid;
>
>  	ice_cfg_itr(hw, q_vector);
>
> -	ice_for_each_tx_ring(tx_ring, q_vector->tx)
> -		ice_cfg_txq_interrupt(vsi, tx_ring->reg_idx, reg_idx,
> -				      q_vector->tx.itr_idx);
> +	for (q = 0; q < q_vector->num_ring_tx; q++) {
> +		ice_cfg_txq_interrupt(vsi, _qid, reg_idx, q_vector->tx.itr_idx);
> +		_qid++;
> +	}
nit: why we need a new variable just for "for" loop ? qid + q wont suffice ?

>