netdev - Re: [PATCH net-next] eth: mlx5: let NETIF_F_NTUPLE float when ARFS is not enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240711133040.GD8788@kernel.org>
Date: Thu, 11 Jul 2024 14:30:40 +0100
From: Simon Horman <horms@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	pabeni@...hat.com, tariqt@...dia.com, rrameshbabu@...dia.com,
	saeedm@...dia.com, yuehaibing@...wei.com, jacob.e.keller@...el.com,
	afaris@...dia.com
Subject: Re: [PATCH net-next] eth: mlx5: let NETIF_F_NTUPLE float when ARFS
 is not enabled

On Wed, Jul 10, 2024 at 10:55:02AM -0700, Jakub Kicinski wrote:
> ARFS depends on NTUPLE filters, but the inverse is not true.
> Drivers which don't support ARFS commonly still support NTUPLE
> filtering. mlx5 has a Kconfig option to disable ARFS (MLX5_EN_ARFS)
> and does not advertise NTUPLE filters as a feature at all when ARFS
> is compiled out. That's not correct, ntuple filters indeed still work
> just fine (as long as MLX5_EN_RXNFC is enabled).
> 
> This is needed to make the RSS test not skip all RSS context
> related testing.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Simon Horman <horms@...nel.org>