netdev - [PATCH net] net: core: sock: add AF_PACKET unsupported binding error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CY5PR11MB6186C896926FDA33E99BD82081A52@CY5PR11MB6186.namprd11.prod.outlook.com>
Date: Thu, 11 Jul 2024 13:48:07 +0000
From: "Szpetkowski, Grzegorz" <grzegorz.szpetkowski@...el.com>
To: "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: [PATCH net] net: core: sock: add AF_PACKET unsupported binding error

Hi All,

Currently, when setsockopt() API with SO_BINDTODEVICE option is
called over a raw packet socket, then although the function doesn't
return an error, the socket is not bound to a specific interface.

The limitation itself is explicitly stated in man 7 socket, particularly
that SO_BINDTODEVICE is "not supported for packet sockets".

The patch below is to align the API, so that it does return failure in
case of a packet socket.

Signed-off-by: Grzegorz Szpetkowski grzegorz.szpetkowski@...el.com
---
 net/core/sock.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/net/core/sock.c b/net/core/sock.c
index 100e975073ca..1b77241ac1f7 100644
--- a/net/core/sock.c
+++ b/net/core/sock.c
@@ -639,6 +639,11 @@ static int sock_bindtoindex_locked(struct sock *sk, int ifindex)
 	if (ifindex < 0)
 		goto out;

+	/* Not supported for packet sockets, use bind() instead */
+	ret = -EOPNOTSUPP;
+	if (sk->sk_family == PF_PACKET)
+		goto out;
+
 	/* Paired with all READ_ONCE() done locklessly. */
 	WRITE_ONCE(sk->sk_bound_dev_if, ifindex);

-- 
2.39.2
---------------------------------------------------------------------
Intel Technology Poland sp. z o.o.
ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN.
Spolka oswiadcza, ze posiada status duzego przedsiebiorcy w rozumieniu ustawy z dnia 8 marca 2013 r. o przeciwdzialaniu nadmiernym opoznieniom w transakcjach handlowych.

Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek przegladanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by others is strictly prohibited.