netdev - Re: [RFC PATCH net-next v6 13/14] virtio/vsock: implement datagram support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMB2axMyA2TDZmXaO_BaFHk4Lh3Ri1LgEc7UU7ZoNsBsqANivQ@mail.gmail.com>
Date: Thu, 11 Jul 2024 16:07:15 -0700
From: Amery Hung <ameryhung@...il.com>
To: Luigi Leonardi <luigi.leonardi@...look.com>
Cc: Bobby Eshleman <bobby.eshleman@...edance.com>, amery.hung@...edance.com, 
	bpf@...r.kernel.org, bryantan@...are.com, dan.carpenter@...aro.org, 
	davem@...emloft.net, decui@...rosoft.com, edumazet@...gle.com, 
	haiyangz@...rosoft.com, jasowang@...hat.com, jiang.wang@...edance.com, 
	kuba@...nel.org, kvm@...r.kernel.org, kys@...rosoft.com, 
	linux-hyperv@...r.kernel.org, linux-kernel@...r.kernel.org, mst@...hat.com, 
	netdev@...r.kernel.org, oxffffaa@...il.com, pabeni@...hat.com, 
	pv-drivers@...are.com, sgarzare@...hat.com, simon.horman@...igine.com, 
	stefanha@...hat.com, vdasa@...are.com, 
	virtualization@...ts.linux-foundation.org, wei.liu@...nel.org, 
	xiyou.wangcong@...il.com, xuanzhuo@...ux.alibaba.com
Subject: Re: [RFC PATCH net-next v6 13/14] virtio/vsock: implement datagram support

On Thu, Jul 11, 2024 at 4:03 PM Luigi Leonardi
<luigi.leonardi@...look.com> wrote:
>
> Hi Bobby, Amery
>
> Thank you for working on this!
>
> > This commit implements datagram support with a new version of
> > ->dgram_allow().
>
> Commit messages should be imperative "This commit implements X" -> "Implements X".
> https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes
> This suggestion applies to many of the commits in this series.

Thanks for pointing this out. I will change the commit message in the
next version.

>
> > +static bool virtio_transport_dgram_allow(u32 cid, u32 port)
> > +{
> > +     struct virtio_vsock *vsock;
> > +     bool dgram_allow;
> > +
> > +     dgram_allow = false;
>
> I think you can initialize the variable in the declaration.

Got it.

Thanks,
Amery

>
> > +     rcu_read_lock();
> > +     vsock = rcu_dereference(the_virtio_vsock);
> > +     if (vsock)
> > +             dgram_allow = vsock->dgram_allow;
> > +     rcu_read_unlock();
> > +
> > +     return dgram_allow;
> > +}
> > +
>
> The rest LGTM.
>
> Thanks,
> Luigi