netdev - Re: [PATCH net-next v1 1/1] net: phy: dp83td510: add cable testing support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3e1103cf-6023-475d-9532-2e5840ed14f8@lunn.ch>
Date: Fri, 12 Jul 2024 17:20:06 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Oleksij Rempel <o.rempel@...gutronix.de>
Cc: Heiner Kallweit <hkallweit1@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	kernel@...gutronix.de, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH net-next v1 1/1] net: phy: dp83td510: add cable testing
 support

> > > +#define DP83TD510E_TDR_CFG2			0x301
> > > +#define DP83TD510E_TDR_END_TAP_INDEX_1		GENMASK(14, 8)
> > > +#define DP83TD510E_TDR_END_TAP_INDEX_1_DEF	36
> > > +#define DP83TD510E_TDR_START_TAP_INDEX_1	GENMASK(6, 0)
> > > +#define DP83TD510E_TDR_START_TAP_INDEX_1_DEF	3
> > 
> > Does this correspond the minimum and maximum distance it will test?
> > Is this 3m to 36m?
> 
> No. At least, i can't confirm it with tests.
> 
> If I see it correctly, this PHY is using SSTDR instead of usual TDR.
> Instead of pulses it will send modulated transmission with default
> length of 16ms
> 
> I tried my best google foo, but was not able to find anything
> understandable about "Start/End tap index for echo coeff sweep for segment 1"
> im context of SSTDR. If anyone know more about this, please tell me :)

I was just curious. Does not really matter with respect to getting the
patch applied.

      Andrew