netdev - Re: net: bnxt: Crash on 6.10 ioctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACKFLikzwRQFJ+wbe5iRYimBmvAwDo2MCHS+unsvUH-=rw8wWA@mail.gmail.com>
Date: Fri, 12 Jul 2024 09:03:06 -0700
From: Michael Chan <michael.chan@...adcom.com>
To: Breno Leitao <leitao@...ian.org>
Cc: kuba@...nel.org, netdev@...r.kernel.org
Subject: Re: net: bnxt: Crash on 6.10 ioctl

On Fri, Jul 12, 2024 at 7:56 AM Breno Leitao <leitao@...ian.org> wrote:
>
> Hello,
>
> Testing commit 24ca36a562 ("Merge tag 'wq-for-6.10-rc5-fixes' of
> git://git.kernel.org/pub/scm/linux/kernel/git/tj/wq") I am getting the
> following crash in bnxt driver:
>
>         BUG: kernel NULL pointer dereference, address: 00000000000000b8
>         #PF: supervisor read access in kernel mode
>         #PF: error_code(0x0000) - not-present page
>         PGD 0 P4D 0
>         Oops: Oops: 0000 [#1] SMP
>         Hardware name: ...
>         RIP: 0010:bnxt_get_max_rss_ctx_ring (drivers/net/ethernet/broadcom/bnxt/bnxt.c:?)

Maybe bp->rss_ctx_list is not valid.

I think we can add this check:

(bp->rss_cap & BNXT_RSS_CAP_MULTI_RSS_CTX)

before proceeding in  bnxt_get_max_rss_ctx_ring().

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4209 bytes)