netdev - Re: [PATCH net-next] net: virtio: fix virtnet_sq_free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240712182021.GC120802@kernel.org>
Date: Fri, 12 Jul 2024 19:20:21 +0100
From: Simon Horman <horms@...nel.org>
To: "Michael S. Tsirkin" <mst@...hat.com>
Cc: Jean-Philippe Brucker <jean-philippe@...aro.org>, jasowang@...hat.com,
	xuanzhuo@...ux.alibaba.com, eperezma@...hat.com,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, virtualization@...ts.linux.dev,
	netdev@...r.kernel.org, Aishwarya TCV <aishwarya.tcv@....com>
Subject: Re: [PATCH net-next] net: virtio: fix virtnet_sq_free_stats
 initialization

On Fri, Jul 12, 2024 at 06:41:34AM -0400, Michael S. Tsirkin wrote:
> On Fri, Jul 12, 2024 at 09:03:30AM +0100, Jean-Philippe Brucker wrote:
> > Commit c8bd1f7f3e61 ("virtio_net: add support for Byte Queue Limits")
> > added two new fields to struct virtnet_sq_free_stats, but commit
> > 23c81a20b998 ("net: virtio: unify code to init stats") accidentally
> > removed their initialization. In the worst case this can trigger the BUG
> > at lib/dynamic_queue_limits.c:99 because dql_completed() receives a
> > random value as count. Initialize the whole structure.
> > 
> > Fixes: 23c81a20b998 ("net: virtio: unify code to init stats")
> > Reported-by: Aishwarya TCV <aishwarya.tcv@....com>
> > Signed-off-by: Jean-Philippe Brucker <jean-philippe@...aro.org>
> 
> 
> Acked-by: Michael S. Tsirkin <mst@...hat.com>
> 
> > ---
> > Both these patches are still in next so it might be possible to fix it
> > up directly.
> 
> I'd be fine with squashing but I don't think it's done in net-next.

True, but this patch doesn't apply to net-next.
And 23c81a20b998 ("net: virtio: unify code to init stats")
isn't present in net-next.

...