netdev - Re: [PATCH -next] gss_krb5: refactor code to return correct PTR_ERR in krb5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <28e91219-6e53-f0e8-52f2-fab055ee3d70@huawei.com>
Date: Fri, 12 Jul 2024 15:25:38 +0800
From: cuigaosheng <cuigaosheng1@...wei.com>
To: Hariprasad Kelam <hkelam@...vell.com>
CC: <trondmy@...nel.org>, <anna@...nel.org>, <chuck.lever@...cle.com>,
	<jlayton@...nel.org>, <neilb@...e.de>, <kolga@...app.com>,
	<Dai.Ngo@...cle.com>, <tom@...pey.com>, <davem@...emloft.net>,
	<edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>,
	<horms@...nel.org>, <linux-nfs@...r.kernel.org>, <netdev@...r.kernel.org>
Subject: Re: [PATCH -next] gss_krb5: refactor code to return correct PTR_ERR
 in krb5_DK

yeah, thanks very much.

On 2024/7/12 15:09, Hariprasad Kelam wrote:
> On 2024-07-12 at 11:33:12, Gaosheng Cui (cuigaosheng1@...wei.com) wrote:
>> Refactor the code in krb5_DK to return PTR_ERR when an error occurs.
>>
>> Signed-off-by: Gaosheng Cui <cuigaosheng1@...wei.com>
>> ---
>>   net/sunrpc/auth_gss/gss_krb5_keys.c | 8 ++++++--
>>   1 file changed, 6 insertions(+), 2 deletions(-)
>>
>> diff --git a/net/sunrpc/auth_gss/gss_krb5_keys.c b/net/sunrpc/auth_gss/gss_krb5_keys.c
>> index 4eb19c3a54c7..b809e646329f 100644
>> --- a/net/sunrpc/auth_gss/gss_krb5_keys.c
>> +++ b/net/sunrpc/auth_gss/gss_krb5_keys.c
>> @@ -164,10 +164,14 @@ static int krb5_DK(const struct gss_krb5_enctype *gk5e,
>>   		goto err_return;
>>   
>>   	cipher = crypto_alloc_sync_skcipher(gk5e->encrypt_name, 0, 0);
>> -	if (IS_ERR(cipher))
>> +	if (IS_ERR(cipher)) {
>> +		ret = IS_ERR(cipher);
>           need to use PTR_ERR?
>
> Thanks,
> Hariprasad k
>
>
> .