[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZpDrLjkCvG3rpxuD@test-OptiPlex-Tower-Plus-7010>
Date: Fri, 12 Jul 2024 14:07:02 +0530
From: Hariprasad Kelam <hkelam@...vell.com>
To: Gaosheng Cui <cuigaosheng1@...wei.com>
CC: <trondmy@...nel.org>, <anna@...nel.org>, <chuck.lever@...cle.com>,
<jlayton@...nel.org>, <neilb@...e.de>, <kolga@...app.com>,
<Dai.Ngo@...cle.com>, <tom@...pey.com>, <davem@...emloft.net>,
<edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>,
<horms@...nel.org>, <linux-nfs@...r.kernel.org>,
<netdev@...r.kernel.org>
Subject: Re: [PATCH -next,v2] gss_krb5: refactor code to return correct
PTR_ERR in krb5_DK
On 2024-07-12 at 12:54:23, Gaosheng Cui (cuigaosheng1@...wei.com) wrote:
> Refactor the code in krb5_DK to return PTR_ERR when an error occurs.
>
nit: Please change "-next" to "net-next" in subject
Reviewed-by: Hariprasad Kelam <hkelam@...vell.com>
> Signed-off-by: Gaosheng Cui <cuigaosheng1@...wei.com>
> ---
> v2: Update IS_ERR to PTR_ERR, thanks very much!
> net/sunrpc/auth_gss/gss_krb5_keys.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/net/sunrpc/auth_gss/gss_krb5_keys.c b/net/sunrpc/auth_gss/gss_krb5_keys.c
> index 4eb19c3a54c7..5ac8d06ab2c0 100644
> --- a/net/sunrpc/auth_gss/gss_krb5_keys.c
> +++ b/net/sunrpc/auth_gss/gss_krb5_keys.c
> @@ -164,10 +164,14 @@ static int krb5_DK(const struct gss_krb5_enctype *gk5e,
> goto err_return;
>
> cipher = crypto_alloc_sync_skcipher(gk5e->encrypt_name, 0, 0);
> - if (IS_ERR(cipher))
> + if (IS_ERR(cipher)) {
> + ret = PTR_ERR(cipher);
> goto err_return;
> + }
> +
> blocksize = crypto_sync_skcipher_blocksize(cipher);
> - if (crypto_sync_skcipher_setkey(cipher, inkey->data, inkey->len))
> + ret = crypto_sync_skcipher_setkey(cipher, inkey->data, inkey->len);
> + if (ret)
> goto err_free_cipher;
>
> ret = -ENOMEM;
> --
> 2.25.1
>
>
Powered by blists - more mailing lists