netdev - Re: [Intel-wired-lan] [PATCH iwl-next v2 3/6] ice: add Tx hang devlink health reporter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240714072333.2fff045c@kernel.org>
Date: Sun, 14 Jul 2024 07:23:33 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Mateusz Polchlopek <mateusz.polchlopek@...el.com>
Cc: intel-wired-lan@...ts.osuosl.org, apw@...onical.com, joe@...ches.com,
 dwaipayanray1@...il.com, lukas.bulwahn@...il.com,
 akpm@...ux-foundation.org, willemb@...gle.com, edumazet@...gle.com,
 linux-kernel@...r.kernel.org, netdev@...r.kernel.org, Przemek Kitszel
 <przemyslaw.kitszel@...el.com>, Igor Bagnucki <igor.bagnucki@...el.com>,
 Wojciech Drewek <wojciech.drewek@...el.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v2 3/6] ice: add Tx hang
 devlink health reporter

On Fri, 12 Jul 2024 05:32:48 -0400 Mateusz Polchlopek wrote:
> +	err = devlink_health_report(reporter, msg, priv_ctx);
> +	if (err) {
> +		struct ice_pf *pf = devlink_health_reporter_priv(reporter);
> +
> +		dev_err(ice_pf_to_dev(pf),
> +			"failed to report %s via devlink health, err %d\n",
> +			msg, err);

My knee-jerk reaction is - why not put it in devlink_health_report()?
Also, I'd rate limit the message.